You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Mateen Mansoori <ma...@gmail.com> on 2021/01/21 10:22:18 UTC

Review Request 73153: Upgrade Ranger Tomcat to 8.5 or 9.0

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73153/
-----------------------------------------------------------

Review request for ranger, Dineshkumar Yadav, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Vishal Suvagia, and Velmurugan Periasamy.


Bugs: RANGER-3105
    https://issues.apache.org/jira/browse/RANGER-3105


Repository: ranger


Description
-------

As Apache tomcat 7.0 support will end on march 2021, I propose to upgrade  version to 8.5 or 9


Diffs
-----

  embeddedwebserver/pom.xml a982f84df 
  embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java 757461da4 
  pom.xml b495809ca 
  security-admin/src/main/webapp/META-INF/context.xml 9c7ea95d7 


Diff: https://reviews.apache.org/r/73153/diff/1/


Testing
-------

Ran : mvn clean compile test verify install : Build was successful.

Tested basic cruds.


Thanks,

Mateen Mansoori


Re: Review Request 73153: Upgrade Ranger Tomcat to 8.5 or 9.0

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73153/#review222524
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On Jan. 25, 2021, 4:51 a.m., Mateen Mansoori wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73153/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2021, 4:51 a.m.)
> 
> 
> Review request for ranger, Dineshkumar Yadav, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Vishal Suvagia, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3105
>     https://issues.apache.org/jira/browse/RANGER-3105
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> As Apache tomcat 7.0 support will end on march 2021, we need to upgrade the version to 8.5 or 9
> 
> 
> Diffs
> -----
> 
>   embeddedwebserver/pom.xml a982f84df 
>   embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java 757461da4 
>   pom.xml b495809ca 
>   security-admin/src/main/webapp/META-INF/context.xml 9c7ea95d7 
> 
> 
> Diff: https://reviews.apache.org/r/73153/diff/1/
> 
> 
> Testing
> -------
> 
> Ran : mvn clean compile test verify install : Build was successful.
> 
> Tested basic cruds.
> 
> Verified tomcat fresh installation on clusters
> 1.kerberos
> 2.kerberos and SSL
> 3.Kerberos, SSL, HA with HAPROXY
> 4.Kerberos and SSL with mysql
> 5.Kerberos and SSL with oracle12
> 6.Kerberos and SSL with java11
> 
> 
> Thanks,
> 
> Mateen Mansoori
> 
>


Re: Review Request 73153: Upgrade Ranger Tomcat to 8.5 or 9.0

Posted by Mehul Parikh <xs...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73153/#review222544
-----------------------------------------------------------


Ship it!




Ship It!

- Mehul Parikh


On Jan. 25, 2021, 4:51 a.m., Mateen Mansoori wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73153/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2021, 4:51 a.m.)
> 
> 
> Review request for ranger, Dineshkumar Yadav, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Vishal Suvagia, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3105
>     https://issues.apache.org/jira/browse/RANGER-3105
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> As Apache tomcat 7.0 support will end on march 2021, we need to upgrade the version to 8.5 or 9
> 
> 
> Diffs
> -----
> 
>   embeddedwebserver/pom.xml a982f84df 
>   embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java 757461da4 
>   pom.xml b495809ca 
>   security-admin/src/main/webapp/META-INF/context.xml 9c7ea95d7 
> 
> 
> Diff: https://reviews.apache.org/r/73153/diff/1/
> 
> 
> Testing
> -------
> 
> Ran : mvn clean compile test verify install : Build was successful.
> 
> Tested basic cruds.
> 
> Verified tomcat fresh installation on clusters
> 1.kerberos
> 2.kerberos and SSL
> 3.Kerberos, SSL, HA with HAPROXY
> 4.Kerberos and SSL with mysql
> 5.Kerberos and SSL with oracle12
> 6.Kerberos and SSL with java11
> 
> 
> Thanks,
> 
> Mateen Mansoori
> 
>


Re: Review Request 73153: Upgrade Ranger Tomcat to 8.5 or 9.0

Posted by Mateen Mansoori <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73153/
-----------------------------------------------------------

(Updated Jan. 25, 2021, 4:51 a.m.)


Review request for ranger, Dineshkumar Yadav, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Vishal Suvagia, and Velmurugan Periasamy.


Bugs: RANGER-3105
    https://issues.apache.org/jira/browse/RANGER-3105


Repository: ranger


Description
-------

As Apache tomcat 7.0 support will end on march 2021, we need to upgrade the version to 8.5 or 9


Diffs
-----

  embeddedwebserver/pom.xml a982f84df 
  embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java 757461da4 
  pom.xml b495809ca 
  security-admin/src/main/webapp/META-INF/context.xml 9c7ea95d7 


Diff: https://reviews.apache.org/r/73153/diff/1/


Testing (updated)
-------

Ran : mvn clean compile test verify install : Build was successful.

Tested basic cruds.

Verified tomcat fresh installation on clusters
1.kerberos
2.kerberos and SSL
3.Kerberos, SSL, HA with HAPROXY
4.Kerberos and SSL with mysql
5.Kerberos and SSL with oracle12
6.Kerberos and SSL with java11


Thanks,

Mateen Mansoori


Re: Review Request 73153: Upgrade Ranger Tomcat to 8.5 or 9.0

Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73153/#review222510
-----------------------------------------------------------



Please add more details and behavior of upgrade case as well. For example whether tomcat 7.0 version created log file shall be reused or not, ssl testing, kerberos testing.

- Pradeep Agrawal


On Jan. 21, 2021, 10:22 a.m., Mateen Mansoori wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73153/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2021, 10:22 a.m.)
> 
> 
> Review request for ranger, Dineshkumar Yadav, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Vishal Suvagia, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3105
>     https://issues.apache.org/jira/browse/RANGER-3105
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> As Apache tomcat 7.0 support will end on march 2021, we need to upgrade the version to 8.5 or 9
> 
> 
> Diffs
> -----
> 
>   embeddedwebserver/pom.xml a982f84df 
>   embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java 757461da4 
>   pom.xml b495809ca 
>   security-admin/src/main/webapp/META-INF/context.xml 9c7ea95d7 
> 
> 
> Diff: https://reviews.apache.org/r/73153/diff/1/
> 
> 
> Testing
> -------
> 
> Ran : mvn clean compile test verify install : Build was successful.
> 
> Tested basic cruds.
> 
> 
> Thanks,
> 
> Mateen Mansoori
> 
>