[GitHub] [guacamole-server] sreid8 edited a comment on issue #159: GUACAMOLE-465: beginning to support new codecs and containers

[GitBox <gi...@apache.org>]

sreid8 edited a comment on issue #159: GUACAMOLE-465: beginning to support new codecs and containers
URL: https://github.com/apache/guacamole-server/pull/159#issuecomment-581142755
 
 
   Hi @mike-jumper. I think I've addressed the comments you had here. I do think it's important that I call out a few changes that I made outside of the requested changes, however. Over the time that this PR has been up, some things had to change, so I updated them.
   
   1. I wrapped the initialization of libavformat in a [similar guard](https://github.com/sreid8/guacamole-server/blob/guacenc_libavformat/src/guacenc/guacenc.c#L84-L86) to the way that the initialization was wrapped for libavcodec because the initialization calls have been deprecated in newer versions of FFmpeg.
   
   2. I added a new macro to ffmpeg-compat.h to handle the change libavcodec made to the `CODEC_FLAG`s. Previously, these were all `CODEC_FLAG_*` format, but now they're `AV_CODEC_FLAG_*` format, so the new macro [`GUACENC_FLAG_GLOBAL_HEADER`](https://github.com/sreid8/guacamole-server/blob/guacenc_libavformat/src/guacenc/ffmpeg-compat.h#L59-L63) resolves that issue.
   
   3. Specifically with regard to the request to document the affect `guacenc_build_avcodeccontext()` has on the `AVStream` that's passed in, I documented the affect in the [header for ffmpeg-compat](https://github.com/sreid8/guacamole-server/blob/guacenc_libavformat/src/guacenc/ffmpeg-compat.h#L91-L95), rather than the source file. I wanted to make sure this is what you had in mind because GitHub isn't enjoying the fact that I don't have a diff on that line as far as resolving the request for change goes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services