You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-dev@hadoop.apache.org by "Zhilei Xu (JIRA)" <ji...@apache.org> on 2014/06/21 04:02:24 UTC
[jira] [Created] (HDFS-6585) INodesInPath.resolve is called
multiple times in FSNamesystem.setPermission
Zhilei Xu created HDFS-6585:
-------------------------------
Summary: INodesInPath.resolve is called multiple times in FSNamesystem.setPermission
Key: HDFS-6585
URL: https://issues.apache.org/jira/browse/HDFS-6585
Project: Hadoop HDFS
Issue Type: Improvement
Components: namenode
Reporter: Zhilei Xu
Assignee: Zhilei Xu
Attachments: patch_ab60af58e03b323dd4b18d32c4def1f008b98822.txt
Most of the APIs (both internal and external) in FSNamesystem calls INodesInPath.resolve() to get the list of INodes corresponding to a file path. Usually one API will call resolve() multiple times and that's a waste of time.
This issue particularly refers to FSNamesystem.setPermission, which calls resolve() twice indirectly: one from checkOwner(), another from dir.setPermission().
Should save the result of resolve(), and use it whenever possible throughout the lifetime of an API call, instead of making new resolve() calls.
--
This message was sent by Atlassian JIRA
(v6.2#6252)