You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "PurelyApplied (GitHub)" <gi...@apache.org> on 2019/02/13 20:03:29 UTC
[GitHub] [geode] PurelyApplied opened pull request #3190: Geode 6399
Depends on PR #3189
Please review in particular the set of published artifacts whose version is constrained by the new BOM. Are there any artifacts that should be exempt from this list?
----
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
[ Full content available at: https://github.com/apache/geode/pull/3190 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] PurelyApplied commented on issue #3190: GEODE-6399:
Manage dependency versions via java-platform
Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
It looks like the NPE was from the `geode-core` serializables class requiring the `geode-core-sanctioned-serializables` to be present in its resource path. It had previously happily gotten the resource from the `geode-core.jar`, but with the constraints in place, was no longer happy to do so.
That seems like convoluted logic in and of itself. And as these tests are a constant source of pain, we should look to shifting their intent into something that is not so brittle when directories or files shift. They might make more sense as gradle commands than as integration tests, since gradle will more easily blow away lingering artifacts that are present in, say, a `lib` or `resource` directory.
[ Full content available at: https://github.com/apache/geode/pull/3190 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] rhoughton-pivot commented on issue #3190:
GEODE-6399: Manage dependency versions via java-platform
Posted by "rhoughton-pivot (GitHub)" <gi...@apache.org>.
`geode-assembly` is publishing a TGZ, but the associated POM contains a dependency on geode-all-bom? Shouldn't the TGZ contain geode-all-bom.pom, instead of depending on it? This is confusing.
[ Full content available at: https://github.com/apache/geode/pull/3190 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] PurelyApplied commented on issue #3190: GEODE-6399:
Manage dependency versions via java-platform
Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
UnitTest failures currently persistent on `develop`. IntegrationTest resource NPEs require investigation.
[ Full content available at: https://github.com/apache/geode/pull/3190 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] PurelyApplied commented on issue #3190: GEODE-6399:
Manage dependency versions via java-platform
Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
As of `99c6bdb`, failures present in this PR were failures in the `develop` pipeline.
[ Full content available at: https://github.com/apache/geode/pull/3190 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] PurelyApplied commented on issue #3190: GEODE-6399:
Manage dependency versions via java-platform
Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
Good catch.
[ Full content available at: https://github.com/apache/geode/pull/3190 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] PurelyApplied commented on issue #3190: GEODE-6399:
Manage dependency versions via java-platform
Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
Failures appear to be (similar to) GEODE-6436 and (exactly) GEODE-6437 in test `RebalanceOperationDUnitTest` and `ClusterConfigLocatorRestartDUnitTest` respectively.
[ Full content available at: https://github.com/apache/geode/pull/3190 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org