[GitHub] [kyuubi] iodone commented on a diff in pull request #4932: [KYUUBI #4925] Add default catalog using `spark_catalog` with the lineage result

["iodone (via GitHub)" <gi...@apache.org>]

iodone commented on code in PR #4932:
URL: https://github.com/apache/kyuubi/pull/4932#discussion_r1246392277


##########
extensions/spark/kyuubi-spark-lineage/src/main/scala/org/apache/kyuubi/plugin/lineage/dispatcher/atlas/AtlasEntityHelper.scala:
##########
@@ -104,33 +104,38 @@ object AtlasEntityHelper {
   }
 
   def tableObjectId(tableName: String): Option[AtlasObjectId] = {
-    val dbTb = tableName.split('.')
-    if (dbTb.length == 2) {
-      val qualifiedName = tableQualifiedName(cluster, dbTb(0), dbTb(1))
-      // TODO parse datasource type
-      Some(new AtlasObjectId(HIVE_TABLE_TYPE, "qualifiedName", qualifiedName))
-    } else {
-      None
+    tableName.split('.') match {
+      case Array(catalog, db, table) =>

Review Comment:
   The implementation here is to merge the catalog into the table name or column name, and the result will be in the form of a string. Does that matter?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org