[GitHub] [zookeeper] ctubbsii edited a comment on pull request #1401: ZOOKEEPER-3888: Add source and target version for compile plugin

[GitBox <gi...@apache.org>]

ctubbsii edited a comment on pull request #1401:
URL: https://github.com/apache/zookeeper/pull/1401#issuecomment-662811359


   > It can not compile due to using jdk1.6 by default. So we would better to specify the version
   
   I agree the version should be specified. However, the version is *already* specified. You are suggesting adding a *second* specification, which is redundant and makes it harder to keep it consistent throughout the project's multiple modules.
   
   The version is currently specified as properties in the parent POM, where it should be (see [this](https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-source-and-target.html) and [this](https://maven.apache.org/plugins/maven-compiler-plugin/compile-mojo.html#source) and [this](https://maven.apache.org/pom.html#Inheritance)).
   
   I'm not sure why yours is failing to build. Are you triggering the build in the child module's directory, or from the root, where the parent POM is located? You should be triggering the build at the root. Also, make sure you aren't specifying `maven.compiler.source` and `maven.compiler.target` anywhere else in your environment such as on the command line or in a custom profile in your `~/.m2/settings.xml` or the super-POM in your Maven installation (which would be a non-standard install, but anything is possible, I suppose).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org