You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Velmurugan Periasamy <vp...@hortonworks.com> on 2016/10/11 16:39:22 UTC
Re: Review Request 51519: Remove PMD "unused" restrictions

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51519/#review152148
-----------------------------------------------------------




hbase-agent/src/main/java/org/apache/ranger/services/hbase/client/HBaseClient.java 
<https://reviews.apache.org/r/51519/#comment220959>

    Colm - Patch does not apply to master branch. Can you please fix this and provide an updated patch?
    
    error: patch failed: hbase-agent/src/main/java/org/apache/ranger/services/hbase/client/HBaseClient.java:48
    error: patch failed: hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/client/HdfsClient.java:45
    error: patch failed: ranger-atlas-plugin-shim/src/main/java/org/apache/ranger/authorization/atlas/authorizer/RangerAtlasAuthorizer.java:23
    error: patch failed: security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java:1519
    error: patch failed: security-admin/src/main/java/org/apache/ranger/service/XAgentService.java:1
    error: patch failed: security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java:307
    error: patch failed: ugsync/src/main/java/org/apache/ranger/unixusersync/poc/RangerUpdateUserGroupMapping.java:1
    error: patch failed: ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java:80


- Velmurugan Periasamy


On Aug. 30, 2016, 12:59 p.m., Colm O hEigeartaigh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51519/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2016, 12:59 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1164
>     https://issues.apache.org/jira/browse/RANGER-1164
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Remove PMD "unused" restrictions
> 
> 
> Diffs
> -----
> 
>   agents-audit/src/main/java/org/apache/ranger/audit/destination/HDFSAuditDestination.java 07023ba 
>   agents-audit/src/main/java/org/apache/ranger/audit/provider/DbAuditProvider.java 34de6f7 
>   agents-common/src/main/java/org/apache/ranger/admin/client/datatype/GrantRevokeData.java b9496be 
>   agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerFileBasedGeolocationProvider.java ea599c7 
>   agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagRetriever.java b6ab8dd 
>   agents-common/src/main/java/org/apache/ranger/plugin/geo/GeolocationMetadata.java 02f4940 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerResourceAccessCacheImpl.java 074b08d 
>   dev-support/ranger-pmd-ruleset.xml d4335a9 
>   hbase-agent/src/main/java/org/apache/ranger/services/hbase/client/HBaseClient.java 0e980b9 
>   hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/client/HdfsClient.java ecc406c 
>   hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveResourceMgr.java 73feff9 
>   plugin-kafka/src/main/java/org/apache/ranger/services/kafka/client/ServiceKafkaConnectionMgr.java c234d09 
>   plugin-solr/src/main/java/org/apache/ranger/services/solr/client/ServiceSolrConnectionMgr.java aece32f 
>   plugin-yarn/src/main/java/org/apache/ranger/services/yarn/client/YarnConnectionMgr.java 58f5146 
>   ranger-atlas-plugin-shim/src/main/java/org/apache/ranger/authorization/atlas/authorizer/RangerAtlasAuthorizer.java d8bdefd 
>   ranger-hbase-plugin-shim/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java 2e404a7 
>   ranger-hdfs-plugin-shim/src/main/java/org/apache/ranger/authorization/hadoop/RangerHdfsAuthorizer.java a19d072 
>   ranger-hive-plugin-shim/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizerFactory.java 14ddd42 
>   ranger-kafka-plugin-shim/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java c88e99f 
>   ranger-storm-plugin-shim/src/main/java/org/apache/ranger/authorization/storm/authorizer/RangerStormAuthorizer.java c7fb35f 
>   ranger-yarn-plugin-shim/src/main/java/org/apache/ranger/authorization/yarn/authorizer/RangerYarnAuthorizer.java 289d1c0 
>   security-admin/src/main/java/org/apache/ranger/common/SearchField.java 2d6ab14 
>   security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java eb4ba2d 
>   security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java b1a2159 
>   security-admin/src/main/java/org/apache/ranger/service/XAgentService.java 8fbb74b 
>   security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java f28ccca 
>   ugsync/ldapconfigchecktool/ldapconfigcheck/src/main/java/org/apache/ranger/ldapconfigcheck/LdapConfig.java 6cd2f83 
>   ugsync/src/main/java/org/apache/ranger/unixusersync/poc/RangerUpdateUserGroupMapping.java 01541db 
>   ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java 17faec1 
>   unixauthclient/src/main/java/org/apache/ranger/authentication/unix/jaas/RemoteUnixLoginModule.java fb52a02 
> 
> Diff: https://reviews.apache.org/r/51519/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>