You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2023/01/06 12:19:04 UTC
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #39368: [SPARK-28764][CORE][TEST] Remove writePartitionedFile in ExternalSorter
HyukjinKwon commented on code in PR #39368:
URL: https://github.com/apache/spark/pull/39368#discussion_r1063392804
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/UnsafeRowSerializerSuite.scala:
##########
@@ -125,7 +130,7 @@ class UnsafeRowSerializerSuite extends SparkFunSuite with LocalSparkSession {
assert(sorter.numSpills > 0)
// Merging spilled files should not throw assertion error
- sorter.writePartitionedFile(ShuffleBlockId(0, 0, 0), outputFile)
+ sorter.writePartitionedMapOutput(0, 0, mapOutputWriter)
Review Comment:
I remember we remove local directories when the JVM (for testing) is shut down. But would be great to confirm that before we merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org