[jira] [Resolved] (CALCITE-2164) Fix alerts raised by lgtm.com

["Julian Hyde (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CALCITE-2164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Hyde resolved CALCITE-2164.
----------------------------------
       Resolution: Fixed
    Fix Version/s: 1.17.0

Fixed in [09be7e74|http://git-wip-us.apache.org/repos/asf/calcite/commit/09be7e74]; thanks for the PR, [~malcolmt]!

> Fix alerts raised by lgtm.com
> -----------------------------
>
>                 Key: CALCITE-2164
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2164
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Malcolm Taylor
>            Assignee: Malcolm Taylor
>            Priority: Major
>             Fix For: 1.17.0
>
>
> lgtm.com has identified a number of places where the code can be improved by small changes. These include cases of
>  * container contents never accessed (so the container can be removed)
>  * reference equality test on boxed types (equals can be used instead)
>  * type mismatch on container access (presumably checking for the wrong object)
>  * boxed variable is never null (primitive type can be used instead)
>  * dereferenced variable may be null (test for null should be added)
>  * useless comparison test (the test can be removed)
> The analysis by lgtm.com can be viewed at [https://lgtm.com/projects/g/apache/calcite/alerts] . This issue is to address some of these alerts



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)