You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/06/06 02:57:51 UTC
[kudu-CR] [java] Add PartialRow addObject API
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13528
Change subject: [java] Add PartialRow addObject API
......................................................................
[java] Add PartialRow addObject API
Adds a new API to add an Object to a PartialRow. This method is useful when you don't care about autoboxing
and your existing type handling logic is based on Java types.
Change-Id: I046de9dba8f4bedae02b82632e26c10c313c775c
---
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
3 files changed, 159 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/13528/1
--
To view, visit http://gerrit.cloudera.org:8080/13528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I046de9dba8f4bedae02b82632e26c10c313c775c
Gerrit-Change-Number: 13528
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [java] Add PartialRow addObject API
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13528 )
Change subject: [java] Add PartialRow addObject API
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13528/1/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
File java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java:
http://gerrit.cloudera.org:8080/#/c/13528/1/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@926
PS1, Line 926: * Type.BOOL -> java.lang.Boolean
: * Type.INT8 -> java.lang.Byte
: * Type.INT16 -> java.lang.Short
: * Type.INT32 -> java.lang.Integer
: * Type.INT64 -> java.lang.Long
: * Type.UNIXTIME_MICROS -> java.sql.Timestamp or java.lang.Long
: * Type.FLOAT -> java.lang.Float
: * Type.DOUBLE -> java.lang.Double
: * Type.STRING -> java.lang.String
: * Type.BINARY -> byte[] or java.lang.ByteBuffer
: * Type.DECIMAL -> java.math.BigDecimal
More type lists to keep up-to-date; are they useful enough to warrant existing?
http://gerrit.cloudera.org:8080/#/c/13528/1/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@978
PS1, Line 978: } else {
Given the nesting in this function, would prefer a return after setNull() rather than this else.
--
To view, visit http://gerrit.cloudera.org:8080/13528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I046de9dba8f4bedae02b82632e26c10c313c775c
Gerrit-Change-Number: 13528
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 06 Jun 2019 05:40:22 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] Add PartialRow addObject API
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13528 )
Change subject: [java] Add PartialRow addObject API
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13528/1/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
File java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java:
http://gerrit.cloudera.org:8080/#/c/13528/1/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@926
PS1, Line 926: * Type.BOOL -> java.lang.Boolean
: * Type.INT8 -> java.lang.Byte
: * Type.INT16 -> java.lang.Short
: * Type.INT32 -> java.lang.Integer
: * Type.INT64 -> java.lang.Long
: * Type.UNIXTIME_MICROS -> java.sql.Timestamp or java.lang.Long
: * Type.FLOAT -> java.lang.Float
: * Type.DOUBLE -> java.lang.Double
: * Type.STRING -> java.lang.String
: * Type.BINARY -> byte[] or java.lang.ByteBuffer
: * Type.DECIMAL -> java.math.BigDecimal
> More type lists to keep up-to-date; are they useful enough to warrant exist
I think so. Given this is public API and these Javadocs are a way for users to understand the expected behavior.
http://gerrit.cloudera.org:8080/#/c/13528/1/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@978
PS1, Line 978: } else {
> Given the nesting in this function, would prefer a return after setNull() r
Done
--
To view, visit http://gerrit.cloudera.org:8080/13528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I046de9dba8f4bedae02b82632e26c10c313c775c
Gerrit-Change-Number: 13528
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 06 Jun 2019 12:47:33 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] Add PartialRow addObject API
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13528 )
Change subject: [java] Add PartialRow addObject API
......................................................................
[java] Add PartialRow addObject API
Adds a new API to add an Object to a PartialRow. This method is useful when you don't care about autoboxing
and your existing type handling logic is based on Java types.
Change-Id: I046de9dba8f4bedae02b82632e26c10c313c775c
Reviewed-on: http://gerrit.cloudera.org:8080/13528
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
3 files changed, 163 insertions(+), 23 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I046de9dba8f4bedae02b82632e26c10c313c775c
Gerrit-Change-Number: 13528
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [java] Add PartialRow addObject API
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13528 )
Change subject: [java] Add PartialRow addObject API
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I046de9dba8f4bedae02b82632e26c10c313c775c
Gerrit-Change-Number: 13528
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 06 Jun 2019 17:29:24 +0000
Gerrit-HasComments: No
[kudu-CR] [java] Add PartialRow addObject API
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Mike Percy, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13528
to look at the new patch set (#2).
Change subject: [java] Add PartialRow addObject API
......................................................................
[java] Add PartialRow addObject API
Adds a new API to add an Object to a PartialRow. This method is useful when you don't care about autoboxing
and your existing type handling logic is based on Java types.
Change-Id: I046de9dba8f4bedae02b82632e26c10c313c775c
---
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
3 files changed, 159 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/13528/2
--
To view, visit http://gerrit.cloudera.org:8080/13528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I046de9dba8f4bedae02b82632e26c10c313c775c
Gerrit-Change-Number: 13528
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [java] Add PartialRow addObject API
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Mike Percy, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13528
to look at the new patch set (#3).
Change subject: [java] Add PartialRow addObject API
......................................................................
[java] Add PartialRow addObject API
Adds a new API to add an Object to a PartialRow. This method is useful when you don't care about autoboxing
and your existing type handling logic is based on Java types.
Change-Id: I046de9dba8f4bedae02b82632e26c10c313c775c
---
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
3 files changed, 163 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/13528/3
--
To view, visit http://gerrit.cloudera.org:8080/13528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I046de9dba8f4bedae02b82632e26c10c313c775c
Gerrit-Change-Number: 13528
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>