You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sentry.apache.org by kalyan kumar kalvagadda <kk...@cloudera.com> on 2017/05/19 23:27:57 UTC

Review Request 59424: SENTRY-1736 Generic service client should support Kerberos(Continuation Fix)

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59424/
-----------------------------------------------------------

Review request for sentry, Alexander Kolbasov and Vamsee Yarlagadda.

Bugs: SENTRY-1736
https://issues.apache.org/jira/browse/SENTRY-1736

Repository: sentry

Description
-------

Older patch had issues as the UserGroupInformation was initialized when the first connection was created. This will not solve the issue as the connection is not created when the sentry client is created. New logic which initialize UserGroupInformation when the first client is created.

This patch is continuation of older patch as the older patch is already committed. This change set also contains tests to make sure things are as expected.

Diffs
-----

sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryTransportFactory.java f609d33
sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestSentryHDFSServiceClientForUgi.java PRE-CREATION
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/TestSentryGenericServiceClientForUgi.java PRE-CREATION
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryPolicyServiceClientForUgi.java PRE-CREATION

Diff: https://reviews.apache.org/r/59424/diff/1/

Testing
-------

Added new tests for this. Test Solr command line till in real cluster.

Thanks,

kalyan kumar kalvagadda

Re: Review Request 59424: SENTRY-1777 Generic service client should support Kerberos(Continuation Fix)

Posted by Na Li <li...@cloudera.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59424/#review175676
-----------------------------------------------------------


Ship it!




Ship It!

- Na Li


On May 22, 2017, 1:03 p.m., kalyan kumar kalvagadda wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59424/
> -----------------------------------------------------------
> 
> (Updated May 22, 2017, 1:03 p.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov and Vamsee Yarlagadda.
> 
> 
> Bugs: SENTRY-1777
>     https://issues.apache.org/jira/browse/SENTRY-1777
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Older patch had issues as the UserGroupInformation was initialized when the first connection was created. This will not solve the issue as the connection is not created when the sentry client is created. New logic which initialize UserGroupInformation when the first client is created.
> 
> This patch is continuation of older patch as the older patch is already committed. This change set also contains tests to make sure things are as expected.
> 
> 
> Diffs
> -----
> 
>   sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryTransportFactory.java f609d33 
>   sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestSentryHDFSServiceClientForUgi.java PRE-CREATION 
>   sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/TestSentryGenericServiceClientForUgi.java PRE-CREATION 
>   sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryPolicyServiceClientForUgi.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59424/diff/1/
> 
> 
> Testing
> -------
> 
> Added new tests for this. Test Solr command line till in real cluster.
> 
> 
> Thanks,
> 
> kalyan kumar kalvagadda
> 
>

Re: Review Request 59424: SENTRY-1777 Generic service client should support Kerberos(Continuation Fix)

Posted by Vamsee Yarlagadda <va...@cloudera.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59424/#review175671
-----------------------------------------------------------


Ship it!




Ship It!

- Vamsee Yarlagadda


On May 22, 2017, 1:03 p.m., kalyan kumar kalvagadda wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59424/
> -----------------------------------------------------------
> 
> (Updated May 22, 2017, 1:03 p.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov and Vamsee Yarlagadda.
> 
> 
> Bugs: SENTRY-1777
>     https://issues.apache.org/jira/browse/SENTRY-1777
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Older patch had issues as the UserGroupInformation was initialized when the first connection was created. This will not solve the issue as the connection is not created when the sentry client is created. New logic which initialize UserGroupInformation when the first client is created.
> 
> This patch is continuation of older patch as the older patch is already committed. This change set also contains tests to make sure things are as expected.
> 
> 
> Diffs
> -----
> 
>   sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryTransportFactory.java f609d33 
>   sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestSentryHDFSServiceClientForUgi.java PRE-CREATION 
>   sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/TestSentryGenericServiceClientForUgi.java PRE-CREATION 
>   sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryPolicyServiceClientForUgi.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59424/diff/1/
> 
> 
> Testing
> -------
> 
> Added new tests for this. Test Solr command line till in real cluster.
> 
> 
> Thanks,
> 
> kalyan kumar kalvagadda
> 
>

Re: Review Request 59424: SENTRY-1777 Generic service client should support Kerberos(Continuation Fix)

Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.

(Updated May 22, 2017, 1:03 p.m.)

Review request for sentry, Alexander Kolbasov and Vamsee Yarlagadda.

Changes
-------

Updated the Jira Id

Summary (updated)
-----------------

SENTRY-1777 Generic service client should support Kerberos(Continuation Fix)

Bugs: SENTRY-1777
https://issues.apache.org/jira/browse/SENTRY-1777

Repository: sentry

Description
-------

This patch is continuation of older patch as the older patch is already committed. This change set also contains tests to make sure things are as expected.

Diffs
-----

Diff: https://reviews.apache.org/r/59424/diff/1/

Testing
-------

Added new tests for this. Test Solr command line till in real cluster.

Thanks,

kalyan kumar kalvagadda

Re: Review Request 59424: SENTRY-1736 Generic service client should support Kerberos(Continuation Fix)

Posted by Alexander Kolbasov <ak...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59424/#review175584
-----------------------------------------------------------



The SENTRY-1736 is already comitted and resolved. Please file another JIRA for subsequent changes.

- Alexander Kolbasov


On May 19, 2017, 11:27 p.m., kalyan kumar kalvagadda wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59424/
> -----------------------------------------------------------
> 
> (Updated May 19, 2017, 11:27 p.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov and Vamsee Yarlagadda.
> 
> 
> Bugs: SENTRY-1736
>     https://issues.apache.org/jira/browse/SENTRY-1736
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Older patch had issues as the UserGroupInformation was initialized when the first connection was created. This will not solve the issue as the connection is not created when the sentry client is created. New logic which initialize UserGroupInformation when the first client is created.
> 
> This patch is continuation of older patch as the older patch is already committed. This change set also contains tests to make sure things are as expected.
> 
> 
> Diffs
> -----
> 
>   sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryTransportFactory.java f609d33 
>   sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestSentryHDFSServiceClientForUgi.java PRE-CREATION 
>   sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/TestSentryGenericServiceClientForUgi.java PRE-CREATION 
>   sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryPolicyServiceClientForUgi.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59424/diff/1/
> 
> 
> Testing
> -------
> 
> Added new tests for this. Test Solr command line till in real cluster.
> 
> 
> Thanks,
> 
> kalyan kumar kalvagadda
> 
>

Re: Review Request 59424: SENTRY-1736 Generic service client should support Kerberos(Continuation Fix)

Posted by Vamsee Yarlagadda <va...@cloudera.com>.


> On May 20, 2017, 12:23 a.m., Vamsee Yarlagadda wrote:
> > Ship It!

Yeah update the review with the new JIRA number.


- Vamsee


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59424/#review175585
-----------------------------------------------------------


On May 19, 2017, 11:27 p.m., kalyan kumar kalvagadda wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59424/
> -----------------------------------------------------------
> 
> (Updated May 19, 2017, 11:27 p.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov and Vamsee Yarlagadda.
> 
> 
> Bugs: SENTRY-1736
>     https://issues.apache.org/jira/browse/SENTRY-1736
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Older patch had issues as the UserGroupInformation was initialized when the first connection was created. This will not solve the issue as the connection is not created when the sentry client is created. New logic which initialize UserGroupInformation when the first client is created.
> 
> This patch is continuation of older patch as the older patch is already committed. This change set also contains tests to make sure things are as expected.
> 
> 
> Diffs
> -----
> 
>   sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryTransportFactory.java f609d33 
>   sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestSentryHDFSServiceClientForUgi.java PRE-CREATION 
>   sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/TestSentryGenericServiceClientForUgi.java PRE-CREATION 
>   sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryPolicyServiceClientForUgi.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59424/diff/1/
> 
> 
> Testing
> -------
> 
> Added new tests for this. Test Solr command line till in real cluster.
> 
> 
> Thanks,
> 
> kalyan kumar kalvagadda
> 
>

Re: Review Request 59424: SENTRY-1736 Generic service client should support Kerberos(Continuation Fix)

Posted by Vamsee Yarlagadda <va...@cloudera.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59424/#review175585
-----------------------------------------------------------


Ship it!




Ship It!

- Vamsee Yarlagadda


On May 19, 2017, 11:27 p.m., kalyan kumar kalvagadda wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59424/
> -----------------------------------------------------------
> 
> (Updated May 19, 2017, 11:27 p.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov and Vamsee Yarlagadda.
> 
> 
> Bugs: SENTRY-1736
>     https://issues.apache.org/jira/browse/SENTRY-1736
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Older patch had issues as the UserGroupInformation was initialized when the first connection was created. This will not solve the issue as the connection is not created when the sentry client is created. New logic which initialize UserGroupInformation when the first client is created.
> 
> This patch is continuation of older patch as the older patch is already committed. This change set also contains tests to make sure things are as expected.
> 
> 
> Diffs
> -----
> 
>   sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryTransportFactory.java f609d33 
>   sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestSentryHDFSServiceClientForUgi.java PRE-CREATION 
>   sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/TestSentryGenericServiceClientForUgi.java PRE-CREATION 
>   sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryPolicyServiceClientForUgi.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59424/diff/1/
> 
> 
> Testing
> -------
> 
> Added new tests for this. Test Solr command line till in real cluster.
> 
> 
> Thanks,
> 
> kalyan kumar kalvagadda
> 
>