[PR] count rows produced instead of getRow() in printRecords(ResultSet) [commons-csv]

["rootvector2 (via GitHub)" <gi...@apache.org>]

rootvector2 opened a new pull request, #627:
URL: https://github.com/apache/commons-csv/pull/627

   `printRecords(ResultSet)` caps `maxRows` with `resultSet.getRow()`, the absolute cursor position. JDBC makes `getRow()` optional for `TYPE_FORWARD_ONLY` result sets and a driver can return `0` there, so `useRow(0)` stays true and the cap is silently skipped while the whole result set streams out; it is also off for a pre-positioned result set. Count the rows produced by this call instead, matching the parser's row-produced counter from CSV-327.
   
   - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
   - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI).
   - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute?
   - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself.
   - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Count rows produced instead of getRow() in printRecords(ResultSet) [commons-csv]

["garydgregory (via GitHub)" <gi...@apache.org>]

garydgregory merged PR #627:
URL: https://github.com/apache/commons-csv/pull/627


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org