[jira] [Updated] (OAK-4591) Clarify implementation and documentation of TarReader#mark

["Michael Dürig (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OAK-4591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Dürig updated OAK-4591:
-------------------------------
    Labels: cleanup gc  (was: )

> Clarify implementation and documentation of TarReader#mark
> ----------------------------------------------------------
>
>                 Key: OAK-4591
>                 URL: https://issues.apache.org/jira/browse/OAK-4591
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segment-tar
>            Reporter: Michael Dürig
>            Assignee: Michael Dürig
>              Labels: cleanup, gc
>             Fix For: Segment Tar 0.0.8
>
>
> There is a few peculiarities with that method:
> * The Javadoc "A bulk segment is reclaimable if it is in bulkRefs" is wrong. It should be "A bulk segment is reclaimable if it is *not* in bulkRefs".
> * (Why) is it necessary to iterate in reverse over the entries in tar file?
> * Why the extra check for bulk references in the else branch?
> * The condition {{!reclaim.remove(id)}} is always true as {{id}} can only be in {{reclaim}} it it had been added in the same iteration (as ids are unique). But this would have been in the if branch, contradicting us being in the else branch. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)