You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Yida Wu (Code Review)" <ge...@cloudera.org> on 2026/05/21 15:37:29 UTC

[Impala-ASF-CR] IMPALA-15030: Fix query-profile-redaction-test failed in UBSAN test

Yida Wu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24341


Change subject: IMPALA-15030: Fix query-profile-redaction-test failed in UBSAN test
......................................................................

IMPALA-15030: Fix query-profile-redaction-test failed in UBSAN test

In recent UBSAN builds, we observed test failures crashing with a
SIGSEGV for query-profile-redaction-test. We only see this crash
happen when evaluating ANALYZED_RE, likely because it is the regex
with the most deep recursion.

UBSAN itself does not directly cause the crash, but it may add
extra instrumentation that increases stack usage for each function
call. The std::regex relied heavily on deep recursive parsing, which
likely resulted in a stack overflow under UBSAN builds.

This patch uses RE2 for resolving this issue. Unlike std::regex
implementation, the RE2 avoids recursive backtracking during regex
evaluation, so more predictable stack and memory usage. To minimize
risk and scope, this patch only replaces ANALYZED_RE with RE2 to
pass the UBSAN build and leaves the remaining regexes unchanged.

Tests:
Passed UBSAN tests.

Change-Id: I9eb1e73e5498761d57e593ef06da2711bfaec19d
---
M be/src/service/query-profile-parsing-tools.cc
M be/src/service/query-profile-redaction.cc
2 files changed, 18 insertions(+), 18 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/24341/1
-- 
To view, visit http://gerrit.cloudera.org:8080/24341
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9eb1e73e5498761d57e593ef06da2711bfaec19d
Gerrit-Change-Number: 24341
Gerrit-PatchSet: 1
Gerrit-Owner: Yida Wu <wy...@gmail.com>

[Impala-ASF-CR] IMPALA-15030: Fix query-profile-redaction-test failed in UBSAN test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24341 )

Change subject: IMPALA-15030: Fix query-profile-redaction-test failed in UBSAN test
......................................................................


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/13532/


-- 
To view, visit http://gerrit.cloudera.org:8080/24341
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9eb1e73e5498761d57e593ef06da2711bfaec19d
Gerrit-Change-Number: 24341
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Thu, 21 May 2026 20:37:48 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15030: Fix query-profile-redaction-test failed in UBSAN test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24341 )

Change subject: IMPALA-15030: Fix query-profile-redaction-test failed in UBSAN test
......................................................................

IMPALA-15030: Fix query-profile-redaction-test failed in UBSAN test

In recent UBSAN builds, we observed test failures crashing with a
SIGSEGV for query-profile-redaction-test. We only see this crash
happen when evaluating ANALYZED_RE, likely because it is the regex
with the most deep recursion.

UBSAN itself does not directly cause the crash, but it may add
extra instrumentation that increases stack usage for each function
call. The std::regex relied heavily on deep recursive parsing, which
likely resulted in a stack overflow under UBSAN builds.

This patch uses RE2 for resolving this issue. Unlike std::regex
implementation, the RE2 avoids recursive backtracking during regex
evaluation, so more predictable stack and memory usage. To minimize
risk and scope, this patch only replaces ANALYZED_RE with RE2 to
pass the UBSAN build and leaves the remaining regexes unchanged.

Tests:
Passed UBSAN tests.

Change-Id: I9eb1e73e5498761d57e593ef06da2711bfaec19d
Reviewed-on: http://gerrit.cloudera.org:8080/24341
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/service/query-profile-parsing-tools.cc
M be/src/service/query-profile-redaction.cc
2 files changed, 17 insertions(+), 17 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/24341
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9eb1e73e5498761d57e593ef06da2711bfaec19d
Gerrit-Change-Number: 24341
Gerrit-PatchSet: 4
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>

[Impala-ASF-CR] IMPALA-15030: Fix query-profile-redaction-test failed in UBSAN test

Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/24341 )

Change subject: IMPALA-15030: Fix query-profile-redaction-test failed in UBSAN test
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24341
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9eb1e73e5498761d57e593ef06da2711bfaec19d
Gerrit-Change-Number: 24341
Gerrit-PatchSet: 1
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 May 2026 16:00:31 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15030: Fix query-profile-redaction-test failed in UBSAN test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24341 )

Change subject: IMPALA-15030: Fix query-profile-redaction-test failed in UBSAN test
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/22570/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24341
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9eb1e73e5498761d57e593ef06da2711bfaec19d
Gerrit-Change-Number: 24341
Gerrit-PatchSet: 1
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 May 2026 15:55:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15030: Fix query-profile-redaction-test failed in UBSAN test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24341 )

Change subject: IMPALA-15030: Fix query-profile-redaction-test failed in UBSAN test
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13534/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/24341
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9eb1e73e5498761d57e593ef06da2711bfaec19d
Gerrit-Change-Number: 24341
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Thu, 21 May 2026 20:42:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15030: Fix query-profile-redaction-test failed in UBSAN test

Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/24341 )

Change subject: IMPALA-15030: Fix query-profile-redaction-test failed in UBSAN test
......................................................................


Patch Set 2:

Rebased in PS2


-- 
To view, visit http://gerrit.cloudera.org:8080/24341
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9eb1e73e5498761d57e593ef06da2711bfaec19d
Gerrit-Change-Number: 24341
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Thu, 21 May 2026 16:13:29 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15030: Fix query-profile-redaction-test failed in UBSAN test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24341 )

Change subject: IMPALA-15030: Fix query-profile-redaction-test failed in UBSAN test
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/24341
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9eb1e73e5498761d57e593ef06da2711bfaec19d
Gerrit-Change-Number: 24341
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Thu, 21 May 2026 20:42:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15030: Fix query-profile-redaction-test failed in UBSAN test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24341 )

Change subject: IMPALA-15030: Fix query-profile-redaction-test failed in UBSAN test
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24341
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9eb1e73e5498761d57e593ef06da2711bfaec19d
Gerrit-Change-Number: 24341
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 22 May 2026 01:07:24 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15030: Fix query-profile-redaction-test failed in UBSAN test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24341 )

Change subject: IMPALA-15030: Fix query-profile-redaction-test failed in UBSAN test
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13532/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/24341
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9eb1e73e5498761d57e593ef06da2711bfaec19d
Gerrit-Change-Number: 24341
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Thu, 21 May 2026 16:15:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15030: Fix query-profile-redaction-test failed in UBSAN test

Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/24341 )

Change subject: IMPALA-15030: Fix query-profile-redaction-test failed in UBSAN test
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24341
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9eb1e73e5498761d57e593ef06da2711bfaec19d
Gerrit-Change-Number: 24341
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Thu, 21 May 2026 16:32:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15030: Fix query-profile-redaction-test failed in UBSAN test

Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/24341 )

Change subject: IMPALA-15030: Fix query-profile-redaction-test failed in UBSAN test
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/24341
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9eb1e73e5498761d57e593ef06da2711bfaec19d
Gerrit-Change-Number: 24341
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Thu, 21 May 2026 17:30:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15030: Fix query-profile-redaction-test failed in UBSAN test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24341 )

Change subject: IMPALA-15030: Fix query-profile-redaction-test failed in UBSAN test
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/22572/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24341
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9eb1e73e5498761d57e593ef06da2711bfaec19d
Gerrit-Change-Number: 24341
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Thu, 21 May 2026 16:34:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15030: Fix query-profile-redaction-test failed in UBSAN test

Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/24341 )

Change subject: IMPALA-15030: Fix query-profile-redaction-test failed in UBSAN test
......................................................................

IMPALA-15030: Fix query-profile-redaction-test failed in UBSAN test

In recent UBSAN builds, we observed test failures crashing with a
SIGSEGV for query-profile-redaction-test. We only see this crash
happen when evaluating ANALYZED_RE, likely because it is the regex
with the most deep recursion.

UBSAN itself does not directly cause the crash, but it may add
extra instrumentation that increases stack usage for each function
call. The std::regex relied heavily on deep recursive parsing, which
likely resulted in a stack overflow under UBSAN builds.

This patch uses RE2 for resolving this issue. Unlike std::regex
implementation, the RE2 avoids recursive backtracking during regex
evaluation, so more predictable stack and memory usage. To minimize
risk and scope, this patch only replaces ANALYZED_RE with RE2 to
pass the UBSAN build and leaves the remaining regexes unchanged.

Tests:
Passed UBSAN tests.

Change-Id: I9eb1e73e5498761d57e593ef06da2711bfaec19d
---
M be/src/service/query-profile-parsing-tools.cc
M be/src/service/query-profile-redaction.cc
2 files changed, 17 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/24341/2
-- 
To view, visit http://gerrit.cloudera.org:8080/24341
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9eb1e73e5498761d57e593ef06da2711bfaec19d
Gerrit-Change-Number: 24341
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>