You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Robbie Gemmell (JIRA)" <ji...@apache.org> on 2010/11/05 17:00:57 UTC
[jira] Created: (QPID-2931) nulling the MessageReference handle on
the Message during QueueEntry release can result in NPE
nulling the MessageReference handle on the Message during QueueEntry release can result in NPE
----------------------------------------------------------------------------------------------
Key: QPID-2931
URL: https://issues.apache.org/jira/browse/QPID-2931
Project: Qpid
Issue Type: Bug
Components: Java Broker
Affects Versions: 0.6
Reporter: Robbie Gemmell
Priority: Critical
Fix For: 0.7
Nulling the MessageReference handle on the Message during QueueEntry release can result in NPE in various places throughout the broker, when attempts from seperate areas of the broker to retrieve details that are held only in the Message overap the reference update and encountere unexpected NPE's. The reference nulling should be removed until this can be acconted for. (It is no longer as necessary as it once was, thanks to more aggressive QueuEntry scavenging in the QueueEntryList's)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2931) nulling the MessageReference handle on
the Message during QueueEntry disposal can result in NPE
Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell updated QPID-2931:
---------------------------------
Description: Nulling the MessageReference handle on the Message during QueueEntry disposal can result in NPE in various places throughout the broker, when attempts from seperate areas of the broker to retrieve details that are held only in the Message overlap the reference update and encounter unexpected NPE's. The reference nulling should be removed until this can be accounted for. (It is no longer as necessary as it once was, thanks to more aggressive QueueEntry scavenging in the QueueEntryList) (was: Nulling the MessageReference handle on the Message during QueueEntry release can result in NPE in various places throughout the broker, when attempts from seperate areas of the broker to retrieve details that are held only in the Message overap the reference update and encountere unexpected NPE's. The reference nulling should be removed until this can be acconted for. (It is no longer as necessary as it once was, thanks to more aggressive QueuEntry scavenging in the QueueEntryList's))
Summary: nulling the MessageReference handle on the Message during QueueEntry disposal can result in NPE (was: nulling the MessageReference handle on the Message during QueueEntry release can result in NPE)
> nulling the MessageReference handle on the Message during QueueEntry disposal can result in NPE
> -----------------------------------------------------------------------------------------------
>
> Key: QPID-2931
> URL: https://issues.apache.org/jira/browse/QPID-2931
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Priority: Critical
> Fix For: 0.7
>
>
> Nulling the MessageReference handle on the Message during QueueEntry disposal can result in NPE in various places throughout the broker, when attempts from seperate areas of the broker to retrieve details that are held only in the Message overlap the reference update and encounter unexpected NPE's. The reference nulling should be removed until this can be accounted for. (It is no longer as necessary as it once was, thanks to more aggressive QueueEntry scavenging in the QueueEntryList)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2931) nulling the MessageReference handle on
the Message during QueueEntry disposal can result in NPE
Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell updated QPID-2931:
---------------------------------
Status: Ready To Review (was: In Progress)
> nulling the MessageReference handle on the Message during QueueEntry disposal can result in NPE
> -----------------------------------------------------------------------------------------------
>
> Key: QPID-2931
> URL: https://issues.apache.org/jira/browse/QPID-2931
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Priority: Critical
> Fix For: 0.7
>
>
> Nulling the MessageReference handle on the Message during QueueEntry disposal can result in NPE in various places throughout the broker, when attempts from seperate areas of the broker to retrieve details that are held only in the Message overlap the reference update and encounter unexpected NPE's. The reference nulling should be removed until this can be accounted for. (It is no longer as necessary as it once was, thanks to more aggressive QueueEntry scavenging in the QueueEntryList)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-2931) nulling the MessageReference handle
on the Message during QueueEntry disposal can result in NPE
Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12929343#action_12929343 ]
Robbie Gemmell commented on QPID-2931:
--------------------------------------
Removed used of the AtomicReferenceUpdater to null/retrieve the entry during release, and replaced with a guarding AtomicBoolean to ensure the continued once-only effect of onRelease() when releasing the MessageReference.
> nulling the MessageReference handle on the Message during QueueEntry disposal can result in NPE
> -----------------------------------------------------------------------------------------------
>
> Key: QPID-2931
> URL: https://issues.apache.org/jira/browse/QPID-2931
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Priority: Critical
> Fix For: 0.7
>
>
> Nulling the MessageReference handle on the Message during QueueEntry disposal can result in NPE in various places throughout the broker, when attempts from seperate areas of the broker to retrieve details that are held only in the Message overlap the reference update and encounter unexpected NPE's. The reference nulling should be removed until this can be accounted for. (It is no longer as necessary as it once was, thanks to more aggressive QueueEntry scavenging in the QueueEntryList)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Assigned: (QPID-2931) nulling the MessageReference handle on
the Message during QueueEntry release can result in NPE
Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell reassigned QPID-2931:
------------------------------------
Assignee: Robbie Gemmell
> nulling the MessageReference handle on the Message during QueueEntry release can result in NPE
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2931
> URL: https://issues.apache.org/jira/browse/QPID-2931
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Priority: Critical
> Fix For: 0.7
>
>
> Nulling the MessageReference handle on the Message during QueueEntry release can result in NPE in various places throughout the broker, when attempts from seperate areas of the broker to retrieve details that are held only in the Message overap the reference update and encountere unexpected NPE's. The reference nulling should be removed until this can be acconted for. (It is no longer as necessary as it once was, thanks to more aggressive QueuEntry scavenging in the QueueEntryList's)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Resolved: (QPID-2931) nulling the MessageReference handle on
the Message during QueueEntry disposal can result in NPE
Posted by "Marnie McCormack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marnie McCormack resolved QPID-2931.
------------------------------------
Resolution: Fixed
Review ok, but we'd possibly be better to fix the NPE handling in the affected areas. Leaving the message handle seems a little wrong, even if it does get scavenged later.
> nulling the MessageReference handle on the Message during QueueEntry disposal can result in NPE
> -----------------------------------------------------------------------------------------------
>
> Key: QPID-2931
> URL: https://issues.apache.org/jira/browse/QPID-2931
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Priority: Critical
> Fix For: 0.7
>
>
> Nulling the MessageReference handle on the Message during QueueEntry disposal can result in NPE in various places throughout the broker, when attempts from seperate areas of the broker to retrieve details that are held only in the Message overlap the reference update and encounter unexpected NPE's. The reference nulling should be removed until this can be accounted for. (It is no longer as necessary as it once was, thanks to more aggressive QueueEntry scavenging in the QueueEntryList)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org