You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/06/18 15:38:30 UTC

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1659: [bugfix] Create service support string type ID. Fix #1654

membphis commented on a change in pull request #1659:
URL: https://github.com/apache/incubator-apisix/pull/1659#discussion_r442320096



##########
File path: t/admin/services.t
##########
@@ -26,12 +26,12 @@ run_tests;
 
 __DATA__
 
-=== TEST 1: set service(id: 1)
+=== TEST 1: set service(id: 5eeb3dc90f747328b2930b0b)

Review comment:
       that is not a good idea to change the old test cases.
   
   you can add new test cases for your new code.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org