You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by am...@apache.org on 2026/09/01 16:21:59 UTC
(superset) 09/15: fix(embedded): say 'chart' in the embed modal when embedding a chart
This is an automated email from the ASF dual-hosted git repository.
amaannawab923 pushed a commit to branch feat/embedded-chart
in repository https://gitbox.apache.org/repos/asf/superset.git
commit c0ad9904adf7bf5957d85a532aa2877b78e185a4
Author: amaannawab923 <am...@gmail.com>
AuthorDate: Tue Sep 1 19:27:52 2026 +0530
fix(embedded): say 'chart' in the embed modal when embedding a chart
The modal is shared with the dashboard flow and its copy was hardcoded to
'dashboard', so a chart embed read 'This dashboard is ready to embed'.
---
.../src/dashboard/components/EmbeddedModal/index.tsx | 20 ++++++++++++++------
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git a/superset-frontend/src/dashboard/components/EmbeddedModal/index.tsx b/superset-frontend/src/dashboard/components/EmbeddedModal/index.tsx
index a77c623b614..df014a88e83 100644
--- a/superset-frontend/src/dashboard/components/EmbeddedModal/index.tsx
+++ b/superset-frontend/src/dashboard/components/EmbeddedModal/index.tsx
@@ -179,18 +179,26 @@ export const DashboardEmbedControls = ({
<DocsConfigDetails embeddedId={embedded.uuid} />
) : (
<p>
- {t(
- 'This dashboard is ready to embed. In your application, pass the following id to the SDK:',
- )}
+ {resourceType === 'chart'
+ ? t(
+ 'This chart is ready to embed. In your application, pass the following id to the SDK:',
+ )
+ : t(
+ 'This dashboard is ready to embed. In your application, pass the following id to the SDK:',
+ )}
<br />
<code>{embedded.uuid}</code>
</p>
)
) : (
<p>
- {t(
- 'Configure this dashboard to embed it into an external web application.',
- )}
+ {resourceType === 'chart'
+ ? t(
+ 'Configure this chart to embed it into an external web application.',
+ )
+ : t(
+ 'Configure this dashboard to embed it into an external web application.',
+ )}
</p>
)}
<p>