You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by dneuman64 <gi...@git.apache.org> on 2017/01/23 17:15:48 UTC
[GitHub] incubator-trafficcontrol pull request #212: Add support for delivery service...
GitHub user dneuman64 opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/212
Add support for delivery service thresholds in goTM
goTM now checks the Total TPS Threshold and Total Kbps Threshold defined on a delivery service and sets a delivery service to available or unavailable accordingly. Also made sure Total TPS was properly calculated and displayed in the DS stats API as well as ensuring delivery service state was correctly reflected in the UI.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dneuman64/incubator-trafficcontrol gotm-ds-static-thresholds
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafficcontrol/pull/212.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #212
----
commit de1467214ad60f495caac91f10f37e77174fdf8f
Author: David Neuman <da...@gmail.com>
Date: 2017-01-17T19:18:12Z
add support for deliveryservice TPS and Kbps thresholds
commit 5bb296c8809fef40110c609799aa636476c9ed3f
Author: David Neuman <da...@gmail.com>
Date: 2017-01-17T21:08:22Z
return a string instead of Stat struct
commit eca28a922e00461442998efdc24993bd62893dae
Author: David Neuman <da...@gmail.com>
Date: 2017-01-18T22:32:37Z
Merge branch 'master' into gotm-ds-static-thresholds
commit 91c7603591799df870802bfd945fca475b3dee93
Author: David Neuman <da...@gmail.com>
Date: 2017-01-19T23:04:53Z
calculate tps_total
commit 6c90f7d594f4143209efbd22e2c842d1f302ec63
Author: David Neuman <da...@gmail.com>
Date: 2017-01-19T23:05:43Z
tps_total is a float not int
commit 50112cc8b2801a535a293c6af7bcd0bf88e93342
Author: David Neuman <da...@gmail.com>
Date: 2017-01-21T02:45:39Z
move getDSErrString so it has the data it needs
commit 0698e8c973bb546b9a7b302f2034574148ecc864
Author: David Neuman <da...@gmail.com>
Date: 2017-01-23T17:09:34Z
make sure thresholds are > 0
commit b4e78366cc393be2cc48e0264b7e6ff26629c4a5
Author: David Neuman <da...@gmail.com>
Date: 2017-01-23T17:09:59Z
correctly display DS Statuses
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #212: Add support for delivery service thresh...
Posted by rob05c <gi...@git.apache.org>.
Github user rob05c commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/212
Other than those 2 little things, looks great. Not enough to -1, if they take more than 5mins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #212: Add support for delivery service...
Posted by rob05c <gi...@git.apache.org>.
Github user rob05c commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/212#discussion_r97406714
--- Diff: traffic_monitor/experimental/traffic_monitor/static/index.html ---
@@ -382,7 +386,7 @@
// \todo check that array has a member before dereferencing [0]
if (jds[deliveryService].hasOwnProperty("isAvailable")) {
- document.getElementById("deliveryservice-stats-" + deliveryService + "-status").textContent = jds[deliveryService]["isAvailable"][0].value ? "available" : "unavailable";
+ document.getElementById("deliveryservice-stats-" + deliveryService + "-status").textContent = jds[deliveryService]["isAvailable"][0].value == "true" ? " available" : "unavailable - " + jds[deliveryService]["error-string"][0].value;
--- End diff --
Is the space before " available" intentional? If so, should "unavailable" also have a space before it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #212: Add support for delivery service...
Posted by dneuman64 <gi...@git.apache.org>.
Github user dneuman64 commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/212#discussion_r97409224
--- Diff: traffic_monitor/experimental/traffic_monitor/deliveryservice/stat.go ---
@@ -72,7 +74,7 @@ func setStaticData(dsStats Stats, dsServers map[enum.DeliveryServiceName][]enum.
return dsStats
}
-func addAvailableData(dsStats Stats, crStates peer.Crstates, serverCachegroups map[enum.CacheName]enum.CacheGroupName, serverDs map[enum.CacheName][]enum.DeliveryServiceName, serverTypes map[enum.CacheName]enum.CacheType, precomputed map[enum.CacheName]cache.PrecomputedData) (Stats, error) {
+func addAvailableData(dsStats Stats, crStates peer.Crstates, serverCachegroups map[enum.CacheName]enum.CacheGroupName, serverDs map[enum.CacheName][]enum.DeliveryServiceName, serverTypes map[enum.CacheName]enum.CacheType, precomputed map[enum.CacheName]cache.PrecomputedData, mc to.TrafficMonitorConfigMap) (Stats, error) {
--- End diff --
ah yes, I missed it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #212: Add support for delivery service...
Posted by rob05c <gi...@git.apache.org>.
Github user rob05c commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/212#discussion_r97405960
--- Diff: traffic_monitor/experimental/traffic_monitor/deliveryservice/stat.go ---
@@ -72,7 +74,7 @@ func setStaticData(dsStats Stats, dsServers map[enum.DeliveryServiceName][]enum.
return dsStats
}
-func addAvailableData(dsStats Stats, crStates peer.Crstates, serverCachegroups map[enum.CacheName]enum.CacheGroupName, serverDs map[enum.CacheName][]enum.DeliveryServiceName, serverTypes map[enum.CacheName]enum.CacheType, precomputed map[enum.CacheName]cache.PrecomputedData) (Stats, error) {
+func addAvailableData(dsStats Stats, crStates peer.Crstates, serverCachegroups map[enum.CacheName]enum.CacheGroupName, serverDs map[enum.CacheName][]enum.DeliveryServiceName, serverTypes map[enum.CacheName]enum.CacheType, precomputed map[enum.CacheName]cache.PrecomputedData, mc to.TrafficMonitorConfigMap) (Stats, error) {
--- End diff --
Looks like `mc` isn't used anymore, can it be removed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #212: Add support for delivery service thresh...
Posted by dneuman64 <gi...@git.apache.org>.
Github user dneuman64 commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/212
@rob05c fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #212: Add support for delivery service...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafficcontrol/pull/212
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---