You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "lidavidm (via GitHub)" <gi...@apache.org> on 2024/04/04 05:39:35 UTC
[PR] build(c): bump vendored fmt [arrow-adbc]
lidavidm opened a new pull request, #1708:
URL: https://github.com/apache/arrow-adbc/pull/1708
This should fix a clang-18-only deprecation warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build(c): bump vendored fmt [arrow-adbc]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #1708:
URL: https://github.com/apache/arrow-adbc/pull/1708#issuecomment-2039706408
> aha, I didn't realize there was a docker image for the clang18 R uses!
More like...a heroic set of individuals attempt to keep up to date with CRAN's check farm ( https://github.com/r-hub/containers/tree/main/containers ). CRAN making vendored libraries the responsibility of the package maintainer is a huge pain (but fine for things like fmt that are ubiquitous). Google C++ libraries are a constant problem (because it's difficult to upstream fixes).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build(c): bump vendored fmt [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #1708:
URL: https://github.com/apache/arrow-adbc/pull/1708#issuecomment-2036320722
ah, the file names conflict now, hmm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build(c): bump vendored fmt [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #1708:
URL: https://github.com/apache/arrow-adbc/pull/1708#issuecomment-2038335842
aha, I didn't realize there was a docker image for the clang18 R uses!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build(c): bump vendored fmt [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #1708:
URL: https://github.com/apache/arrow-adbc/pull/1708
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build(c): bump vendored fmt [arrow-adbc]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #1708:
URL: https://github.com/apache/arrow-adbc/pull/1708#issuecomment-2037420649
Thank you for finding the root cause!
I checked with:
```shell
# docker run --rm -it rhub/clang18
apt-get install -y git libpq-dev
R -e 'install.packages("adbcdrivermanager")'
# Reproduces failure
git clone https://github.com/apache/arrow-adbc.git
cd arrow-adbc/r/adbcpostgresql
PKG_CXXFLAGS=-Werror R CMD INSTALL . --preclean
# /usr/lib/llvm-18/bin/../include/c++/v1/__fwd/string_view.h:22:41: error: 'char_traits<fmt::detail::char8_type>' is deprecated: char_traits<T> for T not equal to char, wchar_t, char8_t, char16_t or char32_t is non-standard and is provided for a temporary period. It will be removed in LLVM 19, so please migrate off of it. [-Werror,-Wdeprecated-declarations]
# Checks that this PR fixes it (it does!)
cd /
git clone https://github.com/lidavidm/arrow-adbc.git
cd arrow-adbc/r/adbcpostgresql
git switch gh-1705
PKG_CXXFLAGS=-Werror R CMD INSTALL . --preclean
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org