You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Zakelly (via GitHub)" <gi...@apache.org> on 2025/09/11 15:16:25 UTC

[PR] [BP-2.0][FLINK-38347][Checkpoint] Tolerate RPC loss for cleanup in file-merging manager [flink]

Zakelly opened a new pull request, #26979:
URL: https://github.com/apache/flink/pull/26979

   ## What is the purpose of the change
   
   In [FLINK-32086](http://issues.apache.org/jira/browse/FLINK-32086), we delete the orphan directories created by file-merging manager. The orphan check depends on the checkpoint notifications. So we should tolerate RPC messages lost, but current implementation using reference counting which does not verify the message completeness using checkpoint id. This PR fixes this by record the checkpoint id that reference the directory to prevent messages mismatch.
   
   ## Brief change log
   
    - Change `DirectoryHandleWithReferenceTrack`, using checkpoint id accounting instead of just single reference count
   
   ## Verifying this change
   
   This change added tests in `testManagedDirCleanup()`, simulating the RPC loss.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [BP-2.0][FLINK-38347][Checkpoint] Tolerate RPC loss for cleanup in file-merging manager [flink]

Posted by "Zakelly (via GitHub)" <gi...@apache.org>.
Zakelly merged PR #26979:
URL: https://github.com/apache/flink/pull/26979


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [BP-2.0][FLINK-38347][Checkpoint] Tolerate RPC loss for cleanup in file-merging manager [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #26979:
URL: https://github.com/apache/flink/pull/26979#issuecomment-3281377795

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "96b34a4bcef497f71153bb619e1b47dbc7f84868",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "96b34a4bcef497f71153bb619e1b47dbc7f84868",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 96b34a4bcef497f71153bb619e1b47dbc7f84868 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org