You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/02/01 17:50:06 UTC

[GitHub] [accumulo] DomGarguilo commented on pull request #2448: Remove seemingly useless method in AgeOffFilterTest

DomGarguilo commented on pull request #2448:
URL: https://github.com/apache/accumulo/pull/2448#issuecomment-1027121008


   > It looks like the test should be creating data that has a TTL such that some data would not be subject to age off. When the age off iterator is run, some data should remain. If this functions as expected, the output would not be an empty map, but the surviving entries. If the test is passing with an empty map, that would suggest that the test is not testing what was intended.
   
   As far as I can tell, `createOutputData()` returns an empty TreeMap. The test does pass with my changes i.e., with an empty map. Maybe this PR should be closed in place of an issue if that is the case.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org