You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "Yicong-Huang (via GitHub)" <gi...@apache.org> on 2026/07/30 03:49:59 UTC
[PR] fix(amber, v1.2): order worker state by version, not timestamp [texera]
Yicong-Huang opened a new pull request, #7106:
URL: https://github.com/apache/texera/pull/7106
### What changes were proposed in this PR?
Backport of #6011 to `release/v1.2`, cherry-picked from f5217504c3cfd8ac1d56f6617d7849895af17f59.
Follows the Direct Backport Push convention; opened as a PR (rather than a direct push) as part of a backport-coverage audit for fixes merged to `main` since early June that were never labeled for backport.
### Any related issues, documentation, discussions?
Backport of #6011. Originally linked #6010.
### How was this PR tested?
Release-branch CI runs once the conflicts are resolved and this PR is marked ready for review. The cherry-pick **conflicted** and was committed with conflict markers.
### Was this PR authored or co-authored using generative AI tooling?
Yes — backport prepared with Claude Code (mechanical cherry-pick; conflicts left as markers for the original author to resolve; the change itself is #6011 by its original author).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(amber, v1.2): order worker state by version, not timestamp [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #7106:
URL: https://github.com/apache/texera/pull/7106#issuecomment-5126210644
### :warning: JUnit XML file not found
The CLI was unable to find any JUnit XML files to upload.
For more help, visit our [troubleshooting guide](https://docs.codecov.com/docs/test-analytics#troubleshooting).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(amber, v1.2): order worker state by version, not timestamp [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7106:
URL: https://github.com/apache/texera/pull/7106#issuecomment-5126199825
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@aglinxinyuan`, `@kunwp1`, `@Ma77Ball`
You can notify them by mentioning `@aglinxinyuan`, `@kunwp1`, `@Ma77Ball` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(amber, v1.2): order worker state by version, not timestamp [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on PR #7106:
URL: https://github.com/apache/texera/pull/7106#issuecomment-5126722399
Resolved — the conflicts were purely `controller`→`coordinator` package-rename drift (that rename is main-only; v1.2 still uses `controller/`), not a feature dependency. Git rename-detection landed 25 of the files cleanly on v1.2's `controller/` paths; I hand-resolved the two source conflicts by keeping v1.2's names and taking the fix's logic:
- `WorkerExecution.scala`: kept the `controller.execution.WorkerPortExecution` import, took the fix's `WorkerState.{COMPLETED, TERMINATED, UNINITIALIZED}` import set.
- `DataProcessor.scala`: kept `controllerInterface` / `mkContext(CONTROLLER)`, adopted `getStateWithVersion` + `WorkerStateUpdatedRequest(state, stateVersion)`.
The `state_version` proto fields and `StateManager.getStateWithVersion` this fix adds are internal RPC/state-ordering plumbing (invisible to users) — this is a correctness fix for out-of-order worker-state application, not a user-facing feature. Dropped two bits of main-only test scaffolding: the new `OperatorExecutionSpec.scala` (added by main under `coordinator/execution/`, no v1.2 counterpart) and two new `WorkflowExecutionSpec` cases that depend on a `regionWithPort` helper absent on v1.2. All other test updates (adapting to the new API) applied cleanly and were kept. Release-branch CI does the authoritative compile. Marking ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(amber, v1.2): order worker state by version, not timestamp [texera]
Posted by "xuang7 (via GitHub)" <gi...@apache.org>.
xuang7 merged PR #7106:
URL: https://github.com/apache/texera/pull/7106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(amber, v1.2): order worker state by version, not timestamp [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on PR #7106:
URL: https://github.com/apache/texera/pull/7106#issuecomment-5126197326
The cherry-pick **conflicted** and was committed with conflict markers. Resolve the conflicts on this branch, then mark this PR ready for review.
**Conflicting files:**
- `amber/src/main/scala/org/apache/texera/amber/engine/architecture/deploysemantics/layer/WorkerExecution.scala`
- `amber/src/main/scala/org/apache/texera/amber/engine/architecture/worker/DataProcessor.scala`
- `amber/src/test/scala/org/apache/texera/amber/engine/architecture/controller/execution/WorkflowExecutionSpec.scala`
- `amber/src/test/scala/org/apache/texera/amber/engine/architecture/coordinator/execution/OperatorExecutionSpec.scala`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org