You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2022/04/23 01:39:03 UTC
[Impala-ASF-CR] IMPALA-11257: Fix CMake warnings for module names and cmake minimum required
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18444
Change subject: IMPALA-11257: Fix CMake warnings for module names and cmake_minimum_required
......................................................................
IMPALA-11257: Fix CMake warnings for module names and cmake_minimum_required
This fixes a few different CMake warnings:
1. This removes cmake_minimum_required invocations except for the
topmost CMakeLists.txt. This eliminates the warnings like this:
Compatibility with CMake < 2.8.12 will be removed from a future version of
CMake.
Update the VERSION argument <min> value or use a ...<max> suffix to tell
CMake that the project does not need compatibility with older versions.
2. This modifies the module names so that they match the corresponding
module names from Find*.cmake. This is mostly dealing with case
differences. This address warnings like:
The package name passed to `find_package_handle_standard_args` (PROTOBUF)
does not match the name of the calling package (Protobuf). This can lead
to problems in calling code that expects `find_package` result variables
(e.g., `_FOUND`) to follow a certain pattern.
3. This adds a missing .cc suffix. This addresses the following warning:
CMake Warning (dev) at be/src/util/CMakeLists.txt:141 (add_library):
Policy CMP0115 is not set: Source file extensions must be explicit. Run
"cmake --help-policy CMP0115" for policy details. Use the cmake_policy
command to set the policy and suppress this warning.
These fixes mostly match how these warnings were handled in
Apache Kudu.
Testing:
- Ran a local build
Change-Id: I2a97dd07cdd0831e90882a2035415ac71d670147
---
M CMakeLists.txt
M be/CMakeLists.txt
M be/src/exec/CMakeLists.txt
M be/src/exec/parquet/CMakeLists.txt
M be/src/testutil/CMakeLists.txt
M be/src/util/CMakeLists.txt
M cmake_modules/FindCrcutil.cmake
M cmake_modules/FindFlatBuffers.cmake
M cmake_modules/FindKerberos.cmake
M cmake_modules/FindKerberosPrograms.cmake
M cmake_modules/FindLibEv.cmake
M cmake_modules/FindLibUnwind.cmake
M cmake_modules/FindProtobuf.cmake
M common/fbs/CMakeLists.txt
M common/function-registry/CMakeLists.txt
M common/protobuf/CMakeLists.txt
M common/thrift/CMakeLists.txt
17 files changed, 9 insertions(+), 30 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/18444/1
--
To view, visit http://gerrit.cloudera.org:8080/18444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2a97dd07cdd0831e90882a2035415ac71d670147
Gerrit-Change-Number: 18444
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-11257: Fix CMake warnings for module names and cmake minimum required
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18444
to look at the new patch set (#6).
Change subject: IMPALA-11257: Fix CMake warnings for module names and cmake_minimum_required
......................................................................
IMPALA-11257: Fix CMake warnings for module names and cmake_minimum_required
This fixes a few different CMake warnings:
1. This removes cmake_minimum_required invocations except for the
top-most CMakeLists.txt. This eliminates the warnings like this:
Compatibility with CMake < 2.8.12 will be removed from a future version of
CMake.
Update the VERSION argument <min> value or use a ...<max> suffix to tell
CMake that the project does not need compatibility with older versions.
Moving to a later version also required setting CMAKE_ENABLE_EXPORTS
to continue exporting symbols.
2. This modifies the module names so that they match the corresponding
module names from Find*.cmake. This is mostly dealing with case
differences. This address warnings like:
The package name passed to `find_package_handle_standard_args` (PROTOBUF)
does not match the name of the calling package (Protobuf). This can lead
to problems in calling code that expects `find_package` result variables
(e.g., `_FOUND`) to follow a certain pattern.
This fixed the detection logic for KerberosPrograms, and so it required
adding more Kerberos packages to bin/bootstrap_build.sh.
3. This adds a missing .cc suffix. This addresses the following warning:
CMake Warning (dev) at be/src/util/CMakeLists.txt:141 (add_library):
Policy CMP0115 is not set: Source file extensions must be explicit. Run
"cmake --help-policy CMP0115" for policy details. Use the cmake_policy
command to set the policy and suppress this warning.
These fixes mostly match how these warnings were handled in
Apache Kudu.
Testing:
- Ran GVO
Change-Id: I2a97dd07cdd0831e90882a2035415ac71d670147
---
M CMakeLists.txt
M be/CMakeLists.txt
M be/src/exec/CMakeLists.txt
M be/src/exec/parquet/CMakeLists.txt
M be/src/testutil/CMakeLists.txt
M be/src/util/CMakeLists.txt
M bin/bootstrap_build.sh
M cmake_modules/FindCrcutil.cmake
M cmake_modules/FindFlatBuffers.cmake
M cmake_modules/FindKerberos.cmake
M cmake_modules/FindKerberosPrograms.cmake
M cmake_modules/FindLibEv.cmake
M cmake_modules/FindLibUnwind.cmake
M cmake_modules/FindProtobuf.cmake
M common/fbs/CMakeLists.txt
M common/function-registry/CMakeLists.txt
M common/protobuf/CMakeLists.txt
M common/thrift/CMakeLists.txt
18 files changed, 21 insertions(+), 33 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/18444/6
--
To view, visit http://gerrit.cloudera.org:8080/18444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2a97dd07cdd0831e90882a2035415ac71d670147
Gerrit-Change-Number: 18444
Gerrit-PatchSet: 6
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11257: Fix CMake warnings for module names and cmake minimum required
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18444 )
Change subject: IMPALA-11257: Fix CMake warnings for module names and cmake_minimum_required
......................................................................
Patch Set 1:
Build Failed
https://ec2-35-162-169-52.us-west-2.compute.amazonaws.com/job/gerrit-code-review-checks/10206/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/18444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a97dd07cdd0831e90882a2035415ac71d670147
Gerrit-Change-Number: 18444
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 23 Apr 2022 01:57:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11257: Fix CMake warnings for module names and cmake minimum required
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18444 )
Change subject: IMPALA-11257: Fix CMake warnings for module names and cmake_minimum_required
......................................................................
IMPALA-11257: Fix CMake warnings for module names and cmake_minimum_required
This fixes a few different CMake warnings:
1. This removes cmake_minimum_required invocations except for the
top-most CMakeLists.txt. This eliminates the warnings like this:
Compatibility with CMake < 2.8.12 will be removed from a future version of
CMake.
Update the VERSION argument <min> value or use a ...<max> suffix to tell
CMake that the project does not need compatibility with older versions.
Moving to a later version also required setting CMAKE_ENABLE_EXPORTS
to continue exporting symbols.
2. This modifies the module names so that they match the corresponding
module names from Find*.cmake. This is mostly dealing with case
differences. This address warnings like:
The package name passed to `find_package_handle_standard_args` (PROTOBUF)
does not match the name of the calling package (Protobuf). This can lead
to problems in calling code that expects `find_package` result variables
(e.g., `_FOUND`) to follow a certain pattern.
This fixed the detection logic for KerberosPrograms, and so it required
adding more Kerberos packages to bin/bootstrap_build.sh.
3. This adds a missing .cc suffix. This addresses the following warning:
CMake Warning (dev) at be/src/util/CMakeLists.txt:141 (add_library):
Policy CMP0115 is not set: Source file extensions must be explicit. Run
"cmake --help-policy CMP0115" for policy details. Use the cmake_policy
command to set the policy and suppress this warning.
These fixes mostly match how these warnings were handled in
Apache Kudu.
Testing:
- Ran GVO
Change-Id: I2a97dd07cdd0831e90882a2035415ac71d670147
Reviewed-on: http://gerrit.cloudera.org:8080/18444
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M CMakeLists.txt
M be/CMakeLists.txt
M be/src/exec/CMakeLists.txt
M be/src/exec/parquet/CMakeLists.txt
M be/src/testutil/CMakeLists.txt
M be/src/util/CMakeLists.txt
M bin/bootstrap_build.sh
M cmake_modules/FindCrcutil.cmake
M cmake_modules/FindFlatBuffers.cmake
M cmake_modules/FindKerberos.cmake
M cmake_modules/FindKerberosPrograms.cmake
M cmake_modules/FindLibEv.cmake
M cmake_modules/FindLibUnwind.cmake
M cmake_modules/FindProtobuf.cmake
M common/fbs/CMakeLists.txt
M common/function-registry/CMakeLists.txt
M common/protobuf/CMakeLists.txt
M common/thrift/CMakeLists.txt
18 files changed, 22 insertions(+), 34 deletions(-)
Approvals:
Joe McDonnell: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/18444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2a97dd07cdd0831e90882a2035415ac71d670147
Gerrit-Change-Number: 18444
Gerrit-PatchSet: 10
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-11257: Fix CMake warnings for module names and cmake minimum required
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18444 )
Change subject: IMPALA-11257: Fix CMake warnings for module names and cmake_minimum_required
......................................................................
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a97dd07cdd0831e90882a2035415ac71d670147
Gerrit-Change-Number: 18444
Gerrit-PatchSet: 7
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Jul 2022 16:57:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11257: Fix CMake warnings for module names and cmake minimum required
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18444 )
Change subject: IMPALA-11257: Fix CMake warnings for module names and cmake_minimum_required
......................................................................
Patch Set 2:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/10485/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/18444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a97dd07cdd0831e90882a2035415ac71d670147
Gerrit-Change-Number: 18444
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 24 Apr 2022 04:31:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11257: Fix CMake warnings for module names and cmake minimum required
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18444 )
Change subject: IMPALA-11257: Fix CMake warnings for module names and cmake_minimum_required
......................................................................
Patch Set 6:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10527/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a97dd07cdd0831e90882a2035415ac71d670147
Gerrit-Change-Number: 18444
Gerrit-PatchSet: 6
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 04 May 2022 05:46:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11257: Fix CMake warnings for module names and cmake minimum required
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18444
to look at the new patch set (#8).
Change subject: IMPALA-11257: Fix CMake warnings for module names and cmake_minimum_required
......................................................................
IMPALA-11257: Fix CMake warnings for module names and cmake_minimum_required
This fixes a few different CMake warnings:
1. This removes cmake_minimum_required invocations except for the
top-most CMakeLists.txt. This eliminates the warnings like this:
Compatibility with CMake < 2.8.12 will be removed from a future version of
CMake.
Update the VERSION argument <min> value or use a ...<max> suffix to tell
CMake that the project does not need compatibility with older versions.
Moving to a later version also required setting CMAKE_ENABLE_EXPORTS
to continue exporting symbols.
2. This modifies the module names so that they match the corresponding
module names from Find*.cmake. This is mostly dealing with case
differences. This address warnings like:
The package name passed to `find_package_handle_standard_args` (PROTOBUF)
does not match the name of the calling package (Protobuf). This can lead
to problems in calling code that expects `find_package` result variables
(e.g., `_FOUND`) to follow a certain pattern.
This fixed the detection logic for KerberosPrograms, and so it required
adding more Kerberos packages to bin/bootstrap_build.sh.
3. This adds a missing .cc suffix. This addresses the following warning:
CMake Warning (dev) at be/src/util/CMakeLists.txt:141 (add_library):
Policy CMP0115 is not set: Source file extensions must be explicit. Run
"cmake --help-policy CMP0115" for policy details. Use the cmake_policy
command to set the policy and suppress this warning.
These fixes mostly match how these warnings were handled in
Apache Kudu.
Testing:
- Ran GVO
Change-Id: I2a97dd07cdd0831e90882a2035415ac71d670147
---
M CMakeLists.txt
M be/CMakeLists.txt
M be/src/exec/CMakeLists.txt
M be/src/exec/parquet/CMakeLists.txt
M be/src/testutil/CMakeLists.txt
M be/src/util/CMakeLists.txt
M bin/bootstrap_build.sh
M cmake_modules/FindCrcutil.cmake
M cmake_modules/FindFlatBuffers.cmake
M cmake_modules/FindKerberos.cmake
M cmake_modules/FindKerberosPrograms.cmake
M cmake_modules/FindLibEv.cmake
M cmake_modules/FindLibUnwind.cmake
M cmake_modules/FindProtobuf.cmake
M common/fbs/CMakeLists.txt
M common/function-registry/CMakeLists.txt
M common/protobuf/CMakeLists.txt
M common/thrift/CMakeLists.txt
18 files changed, 22 insertions(+), 34 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/18444/8
--
To view, visit http://gerrit.cloudera.org:8080/18444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2a97dd07cdd0831e90882a2035415ac71d670147
Gerrit-Change-Number: 18444
Gerrit-PatchSet: 8
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-11257: Fix CMake warnings for module names and cmake minimum required
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18444 )
Change subject: IMPALA-11257: Fix CMake warnings for module names and cmake_minimum_required
......................................................................
Patch Set 9: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a97dd07cdd0831e90882a2035415ac71d670147
Gerrit-Change-Number: 18444
Gerrit-PatchSet: 9
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Aug 2022 05:48:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11257: Fix CMake warnings for module names and cmake minimum required
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18444 )
Change subject: IMPALA-11257: Fix CMake warnings for module names and cmake_minimum_required
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8062/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a97dd07cdd0831e90882a2035415ac71d670147
Gerrit-Change-Number: 18444
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 23 Apr 2022 02:07:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11257: Fix CMake warnings for module names and cmake minimum required
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18444 )
Change subject: IMPALA-11257: Fix CMake warnings for module names and cmake_minimum_required
......................................................................
Patch Set 8: Code-Review+2
Carry +1 from Michael
--
To view, visit http://gerrit.cloudera.org:8080/18444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a97dd07cdd0831e90882a2035415ac71d670147
Gerrit-Change-Number: 18444
Gerrit-PatchSet: 8
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Aug 2022 17:41:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11257: Fix CMake warnings for module names and cmake minimum required
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18444
to look at the new patch set (#4).
Change subject: IMPALA-11257: Fix CMake warnings for module names and cmake_minimum_required
......................................................................
IMPALA-11257: Fix CMake warnings for module names and cmake_minimum_required
This fixes a few different CMake warnings:
1. This removes cmake_minimum_required invocations except for the
topmost CMakeLists.txt. This eliminates the warnings like this:
Compatibility with CMake < 2.8.12 will be removed from a future version of
CMake.
Update the VERSION argument <min> value or use a ...<max> suffix to tell
CMake that the project does not need compatibility with older versions.
Moving to a later version also required setting CMAKE_ENABLE_EXPORTS
to continue exporting symbols.
2. This modifies the module names so that they match the corresponding
module names from Find*.cmake. This is mostly dealing with case
differences. This address warnings like:
The package name passed to `find_package_handle_standard_args` (PROTOBUF)
does not match the name of the calling package (Protobuf). This can lead
to problems in calling code that expects `find_package` result variables
(e.g., `_FOUND`) to follow a certain pattern.
This fixed the detection logic for KerberosPrograms, and so it required
adding more Kerberos packages to bin/bootstrap_build.sh.
3. This adds a missing .cc suffix. This addresses the following warning:
CMake Warning (dev) at be/src/util/CMakeLists.txt:141 (add_library):
Policy CMP0115 is not set: Source file extensions must be explicit. Run
"cmake --help-policy CMP0115" for policy details. Use the cmake_policy
command to set the policy and suppress this warning.
These fixes mostly match how these warnings were handled in
Apache Kudu.
Testing:
- Ran GVO
Change-Id: I2a97dd07cdd0831e90882a2035415ac71d670147
---
M CMakeLists.txt
M be/CMakeLists.txt
M be/src/exec/CMakeLists.txt
M be/src/exec/parquet/CMakeLists.txt
M be/src/testutil/CMakeLists.txt
M be/src/util/CMakeLists.txt
M bin/bootstrap_build.sh
M cmake_modules/FindCrcutil.cmake
M cmake_modules/FindFlatBuffers.cmake
M cmake_modules/FindKerberos.cmake
M cmake_modules/FindKerberosPrograms.cmake
M cmake_modules/FindLibEv.cmake
M cmake_modules/FindLibUnwind.cmake
M cmake_modules/FindProtobuf.cmake
M common/fbs/CMakeLists.txt
M common/function-registry/CMakeLists.txt
M common/protobuf/CMakeLists.txt
M common/thrift/CMakeLists.txt
18 files changed, 20 insertions(+), 32 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/18444/4
--
To view, visit http://gerrit.cloudera.org:8080/18444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2a97dd07cdd0831e90882a2035415ac71d670147
Gerrit-Change-Number: 18444
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11257: Fix CMake warnings for module names and cmake minimum required
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18444 )
Change subject: IMPALA-11257: Fix CMake warnings for module names and cmake_minimum_required
......................................................................
Patch Set 1: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8062/
--
To view, visit http://gerrit.cloudera.org:8080/18444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a97dd07cdd0831e90882a2035415ac71d670147
Gerrit-Change-Number: 18444
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 23 Apr 2022 06:39:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11257: Fix CMake warnings for module names and cmake minimum required
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18444
to look at the new patch set (#2).
Change subject: IMPALA-11257: Fix CMake warnings for module names and cmake_minimum_required
......................................................................
IMPALA-11257: Fix CMake warnings for module names and cmake_minimum_required
This fixes a few different CMake warnings:
1. This removes cmake_minimum_required invocations except for the
topmost CMakeLists.txt. This eliminates the warnings like this:
Compatibility with CMake < 2.8.12 will be removed from a future version of
CMake.
Update the VERSION argument <min> value or use a ...<max> suffix to tell
CMake that the project does not need compatibility with older versions.
2. This modifies the module names so that they match the corresponding
module names from Find*.cmake. This is mostly dealing with case
differences. This address warnings like:
The package name passed to `find_package_handle_standard_args` (PROTOBUF)
does not match the name of the calling package (Protobuf). This can lead
to problems in calling code that expects `find_package` result variables
(e.g., `_FOUND`) to follow a certain pattern.
3. This adds a missing .cc suffix. This addresses the following warning:
CMake Warning (dev) at be/src/util/CMakeLists.txt:141 (add_library):
Policy CMP0115 is not set: Source file extensions must be explicit. Run
"cmake --help-policy CMP0115" for policy details. Use the cmake_policy
command to set the policy and suppress this warning.
These fixes mostly match how these warnings were handled in
Apache Kudu.
Testing:
- Ran a local build
Change-Id: I2a97dd07cdd0831e90882a2035415ac71d670147
---
M CMakeLists.txt
M be/CMakeLists.txt
M be/src/exec/CMakeLists.txt
M be/src/exec/parquet/CMakeLists.txt
M be/src/testutil/CMakeLists.txt
M be/src/util/CMakeLists.txt
M cmake_modules/FindCrcutil.cmake
M cmake_modules/FindFlatBuffers.cmake
M cmake_modules/FindKerberos.cmake
M cmake_modules/FindKerberosPrograms.cmake
M cmake_modules/FindLibEv.cmake
M cmake_modules/FindLibUnwind.cmake
M cmake_modules/FindProtobuf.cmake
M common/fbs/CMakeLists.txt
M common/function-registry/CMakeLists.txt
M common/protobuf/CMakeLists.txt
M common/thrift/CMakeLists.txt
17 files changed, 16 insertions(+), 30 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/18444/2
--
To view, visit http://gerrit.cloudera.org:8080/18444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2a97dd07cdd0831e90882a2035415ac71d670147
Gerrit-Change-Number: 18444
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11257: Fix CMake warnings for module names and cmake minimum required
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18444 )
Change subject: IMPALA-11257: Fix CMake warnings for module names and cmake_minimum_required
......................................................................
Patch Set 3:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/10490/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/18444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a97dd07cdd0831e90882a2035415ac71d670147
Gerrit-Change-Number: 18444
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Apr 2022 18:02:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11257: Fix CMake warnings for module names and cmake minimum required
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18444 )
Change subject: IMPALA-11257: Fix CMake warnings for module names and cmake_minimum_required
......................................................................
Patch Set 7:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10963/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a97dd07cdd0831e90882a2035415ac71d670147
Gerrit-Change-Number: 18444
Gerrit-PatchSet: 7
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Jul 2022 18:28:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11257: Fix CMake warnings for module names and cmake minimum required
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18444 )
Change subject: IMPALA-11257: Fix CMake warnings for module names and cmake_minimum_required
......................................................................
Patch Set 4:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/10491/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/18444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a97dd07cdd0831e90882a2035415ac71d670147
Gerrit-Change-Number: 18444
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Apr 2022 18:28:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11257: Fix CMake warnings for module names and cmake minimum required
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18444 )
Change subject: IMPALA-11257: Fix CMake warnings for module names and cmake_minimum_required
......................................................................
Patch Set 1:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/10484/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/18444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a97dd07cdd0831e90882a2035415ac71d670147
Gerrit-Change-Number: 18444
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 23 Apr 2022 01:57:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11257: Fix CMake warnings for module names and cmake minimum required
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18444
to look at the new patch set (#5).
Change subject: IMPALA-11257: Fix CMake warnings for module names and cmake_minimum_required
......................................................................
IMPALA-11257: Fix CMake warnings for module names and cmake_minimum_required
This fixes a few different CMake warnings:
1. This removes cmake_minimum_required invocations except for the
topmost CMakeLists.txt. This eliminates the warnings like this:
Compatibility with CMake < 2.8.12 will be removed from a future version of
CMake.
Update the VERSION argument <min> value or use a ...<max> suffix to tell
CMake that the project does not need compatibility with older versions.
Moving to a later version also required setting CMAKE_ENABLE_EXPORTS
to continue exporting symbols.
2. This modifies the module names so that they match the corresponding
module names from Find*.cmake. This is mostly dealing with case
differences. This address warnings like:
The package name passed to `find_package_handle_standard_args` (PROTOBUF)
does not match the name of the calling package (Protobuf). This can lead
to problems in calling code that expects `find_package` result variables
(e.g., `_FOUND`) to follow a certain pattern.
This fixed the detection logic for KerberosPrograms, and so it required
adding more Kerberos packages to bin/bootstrap_build.sh.
3. This adds a missing .cc suffix. This addresses the following warning:
CMake Warning (dev) at be/src/util/CMakeLists.txt:141 (add_library):
Policy CMP0115 is not set: Source file extensions must be explicit. Run
"cmake --help-policy CMP0115" for policy details. Use the cmake_policy
command to set the policy and suppress this warning.
These fixes mostly match how these warnings were handled in
Apache Kudu.
Testing:
- Ran GVO
Change-Id: I2a97dd07cdd0831e90882a2035415ac71d670147
---
M CMakeLists.txt
M be/CMakeLists.txt
M be/src/exec/CMakeLists.txt
M be/src/exec/parquet/CMakeLists.txt
M be/src/testutil/CMakeLists.txt
M be/src/util/CMakeLists.txt
M bin/bootstrap_build.sh
M cmake_modules/FindCrcutil.cmake
M cmake_modules/FindFlatBuffers.cmake
M cmake_modules/FindKerberos.cmake
M cmake_modules/FindKerberosPrograms.cmake
M cmake_modules/FindLibEv.cmake
M cmake_modules/FindLibUnwind.cmake
M cmake_modules/FindProtobuf.cmake
M common/fbs/CMakeLists.txt
M common/function-registry/CMakeLists.txt
M common/protobuf/CMakeLists.txt
M common/thrift/CMakeLists.txt
18 files changed, 21 insertions(+), 33 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/18444/5
--
To view, visit http://gerrit.cloudera.org:8080/18444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2a97dd07cdd0831e90882a2035415ac71d670147
Gerrit-Change-Number: 18444
Gerrit-PatchSet: 5
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11257: Fix CMake warnings for module names and cmake minimum required
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18444 )
Change subject: IMPALA-11257: Fix CMake warnings for module names and cmake_minimum_required
......................................................................
Patch Set 8: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a97dd07cdd0831e90882a2035415ac71d670147
Gerrit-Change-Number: 18444
Gerrit-PatchSet: 8
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Aug 2022 16:05:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11257: Fix CMake warnings for module names and cmake minimum required
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18444 )
Change subject: IMPALA-11257: Fix CMake warnings for module names and cmake_minimum_required
......................................................................
Patch Set 9: Code-Review+2
Carry +2
--
To view, visit http://gerrit.cloudera.org:8080/18444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a97dd07cdd0831e90882a2035415ac71d670147
Gerrit-Change-Number: 18444
Gerrit-PatchSet: 9
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Aug 2022 00:55:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11257: Fix CMake warnings for module names and cmake minimum required
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18444 )
Change subject: IMPALA-11257: Fix CMake warnings for module names and cmake_minimum_required
......................................................................
Patch Set 9:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8434/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a97dd07cdd0831e90882a2035415ac71d670147
Gerrit-Change-Number: 18444
Gerrit-PatchSet: 9
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Aug 2022 00:55:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11257: Fix CMake warnings for module names and cmake minimum required
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18444 )
Change subject: IMPALA-11257: Fix CMake warnings for module names and cmake_minimum_required
......................................................................
Patch Set 5:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/10492/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/18444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a97dd07cdd0831e90882a2035415ac71d670147
Gerrit-Change-Number: 18444
Gerrit-PatchSet: 5
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Apr 2022 18:20:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11257: Fix CMake warnings for module names and cmake minimum required
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18444
to look at the new patch set (#3).
Change subject: IMPALA-11257: Fix CMake warnings for module names and cmake_minimum_required
......................................................................
IMPALA-11257: Fix CMake warnings for module names and cmake_minimum_required
This fixes a few different CMake warnings:
1. This removes cmake_minimum_required invocations except for the
topmost CMakeLists.txt. This eliminates the warnings like this:
Compatibility with CMake < 2.8.12 will be removed from a future version of
CMake.
Update the VERSION argument <min> value or use a ...<max> suffix to tell
CMake that the project does not need compatibility with older versions.
Moving to a later version also required setting CMAKE_ENABLE_EXPORTS
to continue exporting symbols.
2. This modifies the module names so that they match the corresponding
module names from Find*.cmake. This is mostly dealing with case
differences. This address warnings like:
The package name passed to `find_package_handle_standard_args` (PROTOBUF)
does not match the name of the calling package (Protobuf). This can lead
to problems in calling code that expects `find_package` result variables
(e.g., `_FOUND`) to follow a certain pattern.
This fixed the detection logic for KerberosPrograms, and so it required
adding more Kerberos packages to bin/bootstrap_build.sh.
3. This adds a missing .cc suffix. This addresses the following warning:
CMake Warning (dev) at be/src/util/CMakeLists.txt:141 (add_library):
Policy CMP0115 is not set: Source file extensions must be explicit. Run
"cmake --help-policy CMP0115" for policy details. Use the cmake_policy
command to set the policy and suppress this warning.
These fixes mostly match how these warnings were handled in
Apache Kudu.
Testing:
- Ran GVO
Change-Id: I2a97dd07cdd0831e90882a2035415ac71d670147
---
M CMakeLists.txt
M be/CMakeLists.txt
M be/src/exec/CMakeLists.txt
M be/src/exec/parquet/CMakeLists.txt
M be/src/testutil/CMakeLists.txt
M be/src/util/CMakeLists.txt
M bin/bootstrap_build.sh
M cmake_modules/FindCrcutil.cmake
M cmake_modules/FindFlatBuffers.cmake
M cmake_modules/FindKerberos.cmake
M cmake_modules/FindKerberosPrograms.cmake
M cmake_modules/FindLibEv.cmake
M cmake_modules/FindLibUnwind.cmake
M cmake_modules/FindProtobuf.cmake
M common/fbs/CMakeLists.txt
M common/function-registry/CMakeLists.txt
M common/protobuf/CMakeLists.txt
M common/thrift/CMakeLists.txt
18 files changed, 18 insertions(+), 32 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/18444/3
--
To view, visit http://gerrit.cloudera.org:8080/18444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2a97dd07cdd0831e90882a2035415ac71d670147
Gerrit-Change-Number: 18444
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11257: Fix CMake warnings for module names and cmake minimum required
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18444 )
Change subject: IMPALA-11257: Fix CMake warnings for module names and cmake_minimum_required
......................................................................
Patch Set 8:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11060/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a97dd07cdd0831e90882a2035415ac71d670147
Gerrit-Change-Number: 18444
Gerrit-PatchSet: 8
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 29 Jul 2022 19:19:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11257: Fix CMake warnings for module names and cmake minimum required
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18444
to look at the new patch set (#7).
Change subject: IMPALA-11257: Fix CMake warnings for module names and cmake_minimum_required
......................................................................
IMPALA-11257: Fix CMake warnings for module names and cmake_minimum_required
This fixes a few different CMake warnings:
1. This removes cmake_minimum_required invocations except for the
top-most CMakeLists.txt. This eliminates the warnings like this:
Compatibility with CMake < 2.8.12 will be removed from a future version of
CMake.
Update the VERSION argument <min> value or use a ...<max> suffix to tell
CMake that the project does not need compatibility with older versions.
Moving to a later version also required setting CMAKE_ENABLE_EXPORTS
to continue exporting symbols.
2. This modifies the module names so that they match the corresponding
module names from Find*.cmake. This is mostly dealing with case
differences. This address warnings like:
The package name passed to `find_package_handle_standard_args` (PROTOBUF)
does not match the name of the calling package (Protobuf). This can lead
to problems in calling code that expects `find_package` result variables
(e.g., `_FOUND`) to follow a certain pattern.
This fixed the detection logic for KerberosPrograms, and so it required
adding more Kerberos packages to bin/bootstrap_build.sh.
3. This adds a missing .cc suffix. This addresses the following warning:
CMake Warning (dev) at be/src/util/CMakeLists.txt:141 (add_library):
Policy CMP0115 is not set: Source file extensions must be explicit. Run
"cmake --help-policy CMP0115" for policy details. Use the cmake_policy
command to set the policy and suppress this warning.
These fixes mostly match how these warnings were handled in
Apache Kudu.
Testing:
- Ran GVO
Change-Id: I2a97dd07cdd0831e90882a2035415ac71d670147
---
M CMakeLists.txt
M be/CMakeLists.txt
M be/src/exec/CMakeLists.txt
M be/src/exec/parquet/CMakeLists.txt
M be/src/testutil/CMakeLists.txt
M be/src/util/CMakeLists.txt
M bin/bootstrap_build.sh
M cmake_modules/FindCrcutil.cmake
M cmake_modules/FindFlatBuffers.cmake
M cmake_modules/FindKerberos.cmake
M cmake_modules/FindKerberosPrograms.cmake
M cmake_modules/FindLibEv.cmake
M cmake_modules/FindLibUnwind.cmake
M cmake_modules/FindProtobuf.cmake
M common/fbs/CMakeLists.txt
M common/function-registry/CMakeLists.txt
M common/protobuf/CMakeLists.txt
M common/thrift/CMakeLists.txt
18 files changed, 22 insertions(+), 34 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/18444/7
--
To view, visit http://gerrit.cloudera.org:8080/18444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2a97dd07cdd0831e90882a2035415ac71d670147
Gerrit-Change-Number: 18444
Gerrit-PatchSet: 7
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>