You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Andrea Turli <no...@github.com> on 2015/06/25 16:13:41 UTC
[jclouds] create java-xmlbuilder.version property for maven (#785)
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/785
-- Commit Summary --
* create java-xmlbuilder.version property for maven
-- File Changes --
M apis/s3/pom.xml (2)
M project/pom.xml (1)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/785.patch
https://github.com/jclouds/jclouds/pull/785.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/785
Re: [jclouds] create java-xmlbuilder.version property for maven
(#785)
Posted by Andrea Turli <no...@github.com>.
thanks @nacx, addressed comments, rebased and squashed.
If the builder is happy, I'll merge it onto master and 1.9.x. Ok?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/785#issuecomment-115741941
Re: [jclouds] create java-xmlbuilder.version property for maven
(#785)
Posted by Andrea Turli <no...@github.com>.
@andrewgaul, @nacx is there anything else I need to do to before merging with 1.9.1-SNAPSHOT as well as 2.0.0-SNAPSHOT? Thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/785#issuecomment-116046500
Re: [jclouds] create java-xmlbuilder.version property for maven
(#785)
Posted by Andrew Gaul <no...@github.com>.
:+1:
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/785#issuecomment-116112316
Re: [jclouds] create java-xmlbuilder.version property for maven
(#785)
Posted by Andrew Gaul <no...@github.com>.
Just FYI I suggested removing java-xmlbuilder in [JCLOUDS-821](https://issues.apache.org/jira/browse/JCLOUDS-821).
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/785#issuecomment-115738403
Re: [jclouds] create java-xmlbuilder.version property for maven
(#785)
Posted by Andrea Turli <no...@github.com>.
Merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/61b06329) and [1.9.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/0aad1387)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/785#issuecomment-116483908
Re: [jclouds] create java-xmlbuilder.version property for maven
(#785)
Posted by Andrea Turli <no...@github.com>.
+1, I'll address this comment and update https://github.com/jclouds/jclouds-labs/pull/180 as well
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/785#issuecomment-115692075
Re: [jclouds] create java-xmlbuilder.version property for maven
(#785)
Posted by Ignasi Barrera <no...@github.com>.
Should it be better, though to add the dependency to the `dependencyManagement` version so the downstream projects don't even have to specify the version?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/785#issuecomment-115679516
Re: [jclouds] create java-xmlbuilder.version property for maven
(#785)
Posted by Andrea Turli <no...@github.com>.
Closed #785.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/785#event-342646348
Re: [jclouds] create java-xmlbuilder.version property for maven
(#785)
Posted by Andrea Turli <no...@github.com>.
thanks guys!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/785#issuecomment-116483970
Re: [jclouds] create java-xmlbuilder.version property for maven
(#785)
Posted by Ignasi Barrera <no...@github.com>.
+1
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/785#issuecomment-115678658
Re: [jclouds] create java-xmlbuilder.version property for maven
(#785)
Posted by Andrea Turli <no...@github.com>.
@andrewgaul I think `azurecompute` in labs uses it quite a lot. Do we want to keep JCLOUDS-821 opened anyway?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/785#issuecomment-115742244