You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by da...@apache.org on 2019/07/26 15:09:28 UTC

[sling-org-apache-sling-feature-analyser] branch master updated: SLING-8601 Analyser for package exports/imports reports about regions even if regions are not used

This is an automated email from the ASF dual-hosted git repository.

davidb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/sling-org-apache-sling-feature-analyser.git


The following commit(s) were added to refs/heads/master by this push:
     new c310704  SLING-8601 Analyser for package exports/imports reports about regions even if regions are not used
c310704 is described below

commit c3107047e603ac7b799b56606340784ae7171029
Author: David Bosschaert <bo...@adobe.com>
AuthorDate: Fri Jul 26 16:09:11 2019 +0100

    SLING-8601 Analyser for package exports/imports reports about regions even if regions are not used
---
 .../sling/feature/analyser/task/impl/CheckBundleExportsImports.java   | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/main/java/org/apache/sling/feature/analyser/task/impl/CheckBundleExportsImports.java b/src/main/java/org/apache/sling/feature/analyser/task/impl/CheckBundleExportsImports.java
index 100e948..f4de6e4 100644
--- a/src/main/java/org/apache/sling/feature/analyser/task/impl/CheckBundleExportsImports.java
+++ b/src/main/java/org/apache/sling/feature/analyser/task/impl/CheckBundleExportsImports.java
@@ -258,7 +258,9 @@ public class CheckBundleExportsImports implements AnalyserTask {
                 for (Map.Entry<PackageInfo, Map.Entry<Set<String>, Set<String>>> regionInfoEntry : entry.getValue().regionInfo.entrySet()) {
                     PackageInfo pkg = regionInfoEntry.getKey();
                     Map.Entry<Set<String>, Set<String>> regions = regionInfoEntry.getValue();
-                    message.append("\n" + pkg.getName() + " is exported in regions " + regions.getKey() + " but it is imported in regions " + regions.getValue());
+                    if (regions.getKey().size() > 0) {
+                        message.append("\n" + pkg.getName() + " is exported in regions " + regions.getKey() + " but it is imported in regions " + regions.getValue());
+                    }
                 }
                 ctx.reportError(message.toString());
                 errorReported = true;