You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/08/16 15:57:45 UTC

[GitHub] dgrove-oss opened a new pull request #3974: Support for start-of-activation log sentinel

dgrove-oss opened a new pull request #3974: Support for start-of-activation log sentinel
URL: https://github.com/apache/incubator-openwhisk/pull/3974
 
 
   <!--- Provide a concise summary of your changes in the Title -->
   
   ## Description
   <!--- Provide a detailed description of your changes. -->
   <!--- Include details of what problem you are solving and how your changes are tested. -->
   
   Add support for filtering out an optional start-of-activation log sentinel
   line that will contain the activation id and namespace in addition to the
   sentinel marker.  For runtimes that inject this sentinel line into their
   outputs, it becomes quite simple to do an asynchronous stream processing
   operation on their log streams and forward log lines enriched with activation ids
   and associated with the appropriate namespace to a platform logging service.
   
   Appended is an example from an action that writes one line to stdout and no lines to stderr:
   
   stdout stream:
   XXX_THE_START_OF_A_WHISK_ACTIVATION_XXX with id cafca5b74be94eb8bca5b74be9beb80f for namespace guest
   Here's a friendly message
   XXX_THE_END_OF_A_WHISK_ACTIVATION_XXX
   
   stderr stream:
   XXX_THE_START_OF_A_WHISK_ACTIVATION_XXX with id cafca5b74be94eb8bca5b74be9beb80f for namespace guest
   XXX_THE_END_OF_A_WHISK_ACTIVATION_XXX
   
   ## Related issue and scope
   <!--- Please include a link to a related issue if there is one. -->
   - [ ] I opened an issue to propose and discuss this change (#????)
   
   ## My changes affect the following components
   <!--- Select below all system components are affected by your change. -->
   <!--- Enter an `x` in all applicable boxes. -->
   - [ ] API
   - [ ] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [x ] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [ ] Tests
   - [ ] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->
   - [ ] Bug fix (generally a non-breaking change which closes an issue).
   - [ x] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
   
   ## Checklist:
   <!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
   
   - [ x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
   - [ ] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).
   - [x ] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [ x] I updated the documentation where necessary.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services