You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by GitBox <gi...@apache.org> on 2022/11/14 19:44:44 UTC
[GitHub] [myfaces] volosied opened a new pull request, #381: Add xml preamble to every ajax response
volosied opened a new pull request, #381:
URL: https://github.com/apache/myfaces/pull/381
https://issues.apache.org/jira/browse/MYFACES-4501
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] volosied commented on a diff in pull request #381: Add xml preamble to every ajax response
Posted by GitBox <gi...@apache.org>.
volosied commented on code in PR #381:
URL: https://github.com/apache/myfaces/pull/381#discussion_r1021997052
##########
api/src/main/java/jakarta/faces/context/PartialResponseWriter.java:
##########
@@ -130,6 +130,8 @@ public void startDocument() throws IOException
// use writePreamble(...)
//_wrapped.write("<?xml version=\"1.0\" encoding=\"utf-8\"?>");
Review Comment:
Maybe I should also use writePreamble()?
I'll update the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] volosied commented on a diff in pull request #381: Add xml preamble to every ajax response
Posted by GitBox <gi...@apache.org>.
volosied commented on code in PR #381:
URL: https://github.com/apache/myfaces/pull/381#discussion_r1022002897
##########
api/src/main/java/jakarta/faces/context/PartialResponseWriter.java:
##########
@@ -130,6 +130,8 @@ public void startDocument() throws IOException
// use writePreamble(...)
//_wrapped.write("<?xml version=\"1.0\" encoding=\"utf-8\"?>");
Review Comment:
Need to make one more change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] melloware merged pull request #381: MYFACES-4501: Add xml preamble to every ajax response
Posted by GitBox <gi...@apache.org>.
melloware merged PR #381:
URL: https://github.com/apache/myfaces/pull/381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] melloware commented on a diff in pull request #381: Add xml preamble to every ajax response
Posted by GitBox <gi...@apache.org>.
melloware commented on code in PR #381:
URL: https://github.com/apache/myfaces/pull/381#discussion_r1021991180
##########
api/src/main/java/jakarta/faces/context/PartialResponseWriter.java:
##########
@@ -130,6 +130,8 @@ public void startDocument() throws IOException
// use writePreamble(...)
//_wrapped.write("<?xml version=\"1.0\" encoding=\"utf-8\"?>");
Review Comment:
remove this commented out line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org