[GitHub] [dubbo] EarthChen commented on a diff in pull request #11965: optimize ThreadlessExecutor

["EarthChen (via GitHub)" <gi...@apache.org>]

EarthChen commented on code in PR #11965:
URL: https://github.com/apache/dubbo/pull/11965#discussion_r1152705441


##########
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleInvoker.java:
##########
@@ -127,12 +128,14 @@ protected Result doInvoke(final Invocation invocation) {
             invocation.getParameterTypes());
         ClientCall call = new TripleClientCall(connectionClient, streamExecutor,
             getUrl().getOrDefaultFrameworkModel(), writeQueue);
-
+        Executor callbackExecutor = getCallbackExecutor(getUrl(), invocation);
         AsyncRpcResult result;
         try {
             switch (methodDescriptor.getRpcType()) {
                 case UNARY:
-                    result = invokeUnary(methodDescriptor, invocation, call);
+                    call = new TripleClientCall(connectionClient, callbackExecutor,

Review Comment:
   The call should not be new twice



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org