You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2023/04/27 16:09:01 UTC
[Impala-ASF-CR] IMPALA-9627: Fix compare branches for Python 3
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19812
Change subject: IMPALA-9627: Fix compare_branches for Python 3
......................................................................
IMPALA-9627: Fix compare_branches for Python 3
Fixes subprocess.check_output calls for Python 3 using
universal_newlines=True.
Change-Id: I3dae9113635cf23ae02f1f630de311e64119c456
---
M bin/compare_branches.py
1 file changed, 8 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/19812/1
--
To view, visit http://gerrit.cloudera.org:8080/19812
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3dae9113635cf23ae02f1f630de311e64119c456
Gerrit-Change-Number: 19812
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-9627: Use universal newlines for Python 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19812 )
Change subject: IMPALA-9627: Use universal_newlines for Python 3
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12892/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19812
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3dae9113635cf23ae02f1f630de311e64119c456
Gerrit-Change-Number: 19812
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Apr 2023 16:35:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9627: Use universal newlines for Python 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19812 )
Change subject: IMPALA-9627: Use universal_newlines for Python 3
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12882/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19812
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3dae9113635cf23ae02f1f630de311e64119c456
Gerrit-Change-Number: 19812
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Apr 2023 16:30:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9627: Use universal newlines for Python 3
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19812
to look at the new patch set (#3).
Change subject: IMPALA-9627: Use universal_newlines for Python 3
......................................................................
IMPALA-9627: Use universal_newlines for Python 3
Fixes subprocess.check_output calls for Python 3 using
universal_newlines=True.
Change-Id: I3dae9113635cf23ae02f1f630de311e64119c456
---
M bin/compare_branches.py
M bin/get_code_size.py
M docker/monitor.py
M docker/test-with-docker.py
M tests/common/impala_service.py
5 files changed, 18 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/19812/3
--
To view, visit http://gerrit.cloudera.org:8080/19812
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3dae9113635cf23ae02f1f630de311e64119c456
Gerrit-Change-Number: 19812
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-9627: Use universal newlines for Python 3
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19812 )
Change subject: IMPALA-9627: Use universal_newlines for Python 3
......................................................................
Patch Set 3: Code-Review+1
I ran this compare_branches.py command it works fine with python2 and python3:
bin/compare_branches.py --source_remote_name origin --source_branch master --target_remote_name origin --target_branch branch-4.1.1
There are various committers with Unicode in their names, so that is a sanity check.
One small thing: I did "git grep -A2 check_output"
I see one or two check_output calls that might also need this:
bin/start-impala-cluster.py (stuff around docker port and docker network inspect)
test/common/impala_cluster.py (stuff around docker network inspect)
--
To view, visit http://gerrit.cloudera.org:8080/19812
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3dae9113635cf23ae02f1f630de311e64119c456
Gerrit-Change-Number: 19812
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Apr 2023 00:54:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9627: Use universal newlines for Python 3
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19812 )
Change subject: IMPALA-9627: Use universal_newlines for Python 3
......................................................................
Patch Set 3:
> Patch Set 3: Code-Review+1
>
> I ran this compare_branches.py command it works fine with python2 and python3:
> bin/compare_branches.py --source_remote_name origin --source_branch master --target_remote_name origin --target_branch branch-4.1.1
> There are various committers with Unicode in their names, so that is a sanity check.
>
> One small thing: I did "git grep -A2 check_output"
> I see one or two check_output calls that might also need this:
> bin/start-impala-cluster.py (stuff around docker port and docker network inspect)
> test/common/impala_cluster.py (stuff around docker network inspect)
They're safe uses, but I can update them anyway.
--
To view, visit http://gerrit.cloudera.org:8080/19812
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3dae9113635cf23ae02f1f630de311e64119c456
Gerrit-Change-Number: 19812
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Apr 2023 16:12:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9627: Use universal newlines for Python 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19812 )
Change subject: IMPALA-9627: Use universal_newlines for Python 3
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19812
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3dae9113635cf23ae02f1f630de311e64119c456
Gerrit-Change-Number: 19812
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Apr 2023 23:28:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9627: Use universal newlines for Python 3
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19812
to look at the new patch set (#4).
Change subject: IMPALA-9627: Use universal_newlines for Python 3
......................................................................
IMPALA-9627: Use universal_newlines for Python 3
Fixes subprocess.check_output calls for Python 3 using
universal_newlines=True.
Change-Id: I3dae9113635cf23ae02f1f630de311e64119c456
---
M bin/compare_branches.py
M bin/get_code_size.py
M bin/start-impala-cluster.py
M docker/monitor.py
M docker/test-with-docker.py
M tests/common/impala_cluster.py
M tests/common/impala_service.py
7 files changed, 26 insertions(+), 19 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/19812/4
--
To view, visit http://gerrit.cloudera.org:8080/19812
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3dae9113635cf23ae02f1f630de311e64119c456
Gerrit-Change-Number: 19812
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-9627: Use universal newlines for Python 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19812 )
Change subject: IMPALA-9627: Use universal_newlines for Python 3
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12885/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19812
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3dae9113635cf23ae02f1f630de311e64119c456
Gerrit-Change-Number: 19812
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Apr 2023 16:42:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9627: Use universal newlines for Python 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19812 )
Change subject: IMPALA-9627: Use universal_newlines for Python 3
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12884/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19812
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3dae9113635cf23ae02f1f630de311e64119c456
Gerrit-Change-Number: 19812
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Apr 2023 16:42:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9627: Use universal newlines for Python 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19812 )
Change subject: IMPALA-9627: Use universal_newlines for Python 3
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9266/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/19812
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3dae9113635cf23ae02f1f630de311e64119c456
Gerrit-Change-Number: 19812
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Apr 2023 18:11:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9627: Use universal newlines for Python 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19812 )
Change subject: IMPALA-9627: Use universal_newlines for Python 3
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19812
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3dae9113635cf23ae02f1f630de311e64119c456
Gerrit-Change-Number: 19812
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Apr 2023 18:11:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9627: Use universal newlines for Python 3
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19812 )
Change subject: IMPALA-9627: Use universal_newlines for Python 3
......................................................................
Patch Set 4: Code-Review+2
Thanks for putting this together
--
To view, visit http://gerrit.cloudera.org:8080/19812
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3dae9113635cf23ae02f1f630de311e64119c456
Gerrit-Change-Number: 19812
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Apr 2023 16:31:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9627: Use universal newlines for Python 3
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19812
to look at the new patch set (#2).
Change subject: IMPALA-9627: Use universal_newlines for Python 3
......................................................................
IMPALA-9627: Use universal_newlines for Python 3
Fixes subprocess.check_output calls for Python 3 using
universal_newlines=True.
Change-Id: I3dae9113635cf23ae02f1f630de311e64119c456
---
M bin/compare_branches.py
M bin/get_code_size.py
M docker/monitor.py
M docker/test-with-docker.py
M tests/common/impala_service.py
5 files changed, 18 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/19812/2
--
To view, visit http://gerrit.cloudera.org:8080/19812
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3dae9113635cf23ae02f1f630de311e64119c456
Gerrit-Change-Number: 19812
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-9627: Use universal newlines for Python 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19812 )
Change subject: IMPALA-9627: Use universal_newlines for Python 3
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/19812/2/bin/get_code_size.py
File bin/get_code_size.py:
http://gerrit.cloudera.org:8080/#/c/19812/2/bin/get_code_size.py@33
PS2, Line 33:
flake8: W291 trailing whitespace
http://gerrit.cloudera.org:8080/#/c/19812/2/bin/get_code_size.py@33
PS2, Line 33: data = subprocess.check_output(["size", "-B", "-t", file],
line has trailing whitespace
--
To view, visit http://gerrit.cloudera.org:8080/19812
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3dae9113635cf23ae02f1f630de311e64119c456
Gerrit-Change-Number: 19812
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Apr 2023 16:21:04 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9627: Use universal newlines for Python 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19812 )
Change subject: IMPALA-9627: Use universal_newlines for Python 3
......................................................................
IMPALA-9627: Use universal_newlines for Python 3
Fixes subprocess.check_output calls for Python 3 using
universal_newlines=True.
Change-Id: I3dae9113635cf23ae02f1f630de311e64119c456
Reviewed-on: http://gerrit.cloudera.org:8080/19812
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/compare_branches.py
M bin/get_code_size.py
M bin/start-impala-cluster.py
M docker/monitor.py
M docker/test-with-docker.py
M tests/common/impala_cluster.py
M tests/common/impala_service.py
7 files changed, 26 insertions(+), 19 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/19812
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3dae9113635cf23ae02f1f630de311e64119c456
Gerrit-Change-Number: 19812
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>