You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "martinzink (via GitHub)" <gi...@apache.org> on 2023/02/28 14:00:44 UTC
[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1517: MINIFICPP-2048 ARM64 support part 1
martinzink commented on code in PR #1517:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1517#discussion_r1120105778
##########
thirdparty/ossp-uuid/ossp-uuid-update-config-guess.patch:
##########
@@ -0,0 +1,5538 @@
+ diff --git a/config.guess b/config.guess
+index ca2a03c..69188da 100755
+--- a/config.guess
++++ b/config.guess
Review Comment:
They are the newer version of the included config.guess and config.sub
https://git.savannah.gnu.org/gitweb/?p=config.git;a=blob_plain;f=config.guess
https://git.savannah.gnu.org/gitweb/?p=config.git;a=blob_plain;f=config.sub
##########
libminifi/test/unit/StringUtilsTests.cpp:
##########
@@ -388,30 +390,22 @@ TEST_CASE("TestStringUtils::testBase64Decode", "[test base64 decode]") {
REQUIRE("oooooo" == StringUtils::from_base64("b29vb29v", as_string));
REQUIRE("\xfb\xff\xbf" == StringUtils::from_base64("-_-_", as_string));
REQUIRE("\xfb\xff\xbf" == StringUtils::from_base64("+/+/", as_string));
- REQUIRE(std::string({ 0, 16, -125, 16,
- 81, -121, 32, -110,
- -117, 48, -45, -113,
- 65, 20, -109, 81,
- 85, -105, 97, -106,
- -101, 113, -41, -97,
- -126, 24, -93, -110,
- 89, -89, -94, -102,
- -85, -78, -37, -81,
- -61, 28, -77, -45,
- 93, -73, -29, -98,
- -69, -13, -33, -65}) == StringUtils::from_base64("ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/", as_string));
- REQUIRE(std::string({ 0, 16, -125, 16,
- 81, -121, 32, -110,
- -117, 48, -45, -113,
- 65, 20, -109, 81,
- 85, -105, 97, -106,
- -101, 113, -41, -97,
- -126, 24, -93, -110,
- 89, -89, -94, -102,
- -85, -78, -37, -81,
- -61, 28, -77, -45,
- 93, -73, -29, -98,
- -69, -13, -33, -65}) == StringUtils::from_base64("ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789-_", as_string));
+ std::string expected{
+ static_cast<char>(0), static_cast<char>(16), static_cast<char>(-125), static_cast<char>(16),
+ static_cast<char>(81), static_cast<char>(-121), static_cast<char>(32), static_cast<char>(-110),
+ static_cast<char>(-117), static_cast<char>(48), static_cast<char>(-45), static_cast<char>(-113),
+ static_cast<char>(65), static_cast<char>(20), static_cast<char>(-109), static_cast<char>(81),
+ static_cast<char>(85), static_cast<char>(-105), static_cast<char>(97), static_cast<char>(-106),
+ static_cast<char>(-101), static_cast<char>(113), static_cast<char>(-41), static_cast<char>(-97),
+ static_cast<char>(-126), static_cast<char>(24), static_cast<char>(-93), static_cast<char>(-110),
+ static_cast<char>(89), static_cast<char>(-89), static_cast<char>(-94), static_cast<char>(-102),
+ static_cast<char>(-85), static_cast<char>(-78), static_cast<char>(-37), static_cast<char>(-81),
+ static_cast<char>(-61), static_cast<char>(28), static_cast<char>(-77), static_cast<char>(-45),
+ static_cast<char>(93), static_cast<char>(-73), static_cast<char>(-29), static_cast<char>(-98),
+ static_cast<char>(-69), static_cast<char>(-13), static_cast<char>(-33), static_cast<char>(-65)};
Review Comment:
Good idea, unfortunetly this version fails for some reason on my machine. But I've created [something similar](https://github.com/apache/nifi-minifi-cpp/pull/1517/commits/8526c237224d7f9a67d88bc0fca6428e1e873083) based on your idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org