[GitHub] [openwhisk] bdoyle0182 commented on a diff in pull request #5252: Use pureconfig for invoker/scheduler's basic http auth

[GitBox <gi...@apache.org>]

bdoyle0182 commented on code in PR #5252:
URL: https://github.com/apache/openwhisk/pull/5252#discussion_r883879375


##########
core/invoker/src/main/resources/application.conf:
##########
@@ -176,6 +176,8 @@ whisk {
   }
 
   invoker {
+    username: "invoker.user"

Review Comment:
   Should there be an equivalent default config for the scheduler?
   
   Also don't know off the top of my head but is `.` a special character for curl requests? Wouldn't want to make it harder to curl the invoker with a special character for those that don't care about creds and just using the default



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org