svn commit: r618220 - in /portals/pluto/trunk: pluto-portal-driver-impl/src/main/java/org/apache/pluto/driver/url/impl/PortalURLParserImpl.java portlet2-api/src/main/java/javax/portlet/ActionResponse.java

[de...@apache.org]

Author: dettborn
Date: Mon Feb  4 01:53:21 2008
New Revision: 618220

URL: http://svn.apache.org/viewvc?rev=618220&view=rev
Log:
Applied toString.patch from pluto#464. thanks Nils-Helge
add license header in ActionResponse.java thanks Ate

Modified:
    portals/pluto/trunk/pluto-portal-driver-impl/src/main/java/org/apache/pluto/driver/url/impl/PortalURLParserImpl.java
    portals/pluto/trunk/portlet2-api/src/main/java/javax/portlet/ActionResponse.java

Modified: portals/pluto/trunk/pluto-portal-driver-impl/src/main/java/org/apache/pluto/driver/url/impl/PortalURLParserImpl.java
URL: http://svn.apache.org/viewvc/portals/pluto/trunk/pluto-portal-driver-impl/src/main/java/org/apache/pluto/driver/url/impl/PortalURLParserImpl.java?rev=618220&r1=618219&r2=618220&view=diff
==============================================================================
--- portals/pluto/trunk/pluto-portal-driver-impl/src/main/java/org/apache/pluto/driver/url/impl/PortalURLParserImpl.java (original)
+++ portals/pluto/trunk/pluto-portal-driver-impl/src/main/java/org/apache/pluto/driver/url/impl/PortalURLParserImpl.java Mon Feb  4 01:53:21 2008
@@ -354,13 +354,15 @@
     private String encodeMultiValues(String[] values) {
     	StringBuffer buffer = new StringBuffer();
         for (int i = 0; i < values.length; i++) {
+        	// Do not operate on the array reference
+        	String currentValue = values[i];
         	try {
-        		if (values[i] != null)
-        			values[i] = URLEncoder.encode(values[i], "UTF-8");
+        		if (currentValue != null)
+        			currentValue = URLEncoder.encode(values[i], "UTF-8");
 			} catch (UnsupportedEncodingException e) {
 				LOG.warn(e);
 			}
-        	buffer.append(values[i] != null ? values[i] : "");
+        	buffer.append(currentValue != null ? currentValue : "");
             if (i + 1 < values.length) {
             	buffer.append(VALUE_DELIM);
             }

Modified: portals/pluto/trunk/portlet2-api/src/main/java/javax/portlet/ActionResponse.java
URL: http://svn.apache.org/viewvc/portals/pluto/trunk/portlet2-api/src/main/java/javax/portlet/ActionResponse.java?rev=618220&r1=618219&r2=618220&view=diff
==============================================================================
--- portals/pluto/trunk/portlet2-api/src/main/java/javax/portlet/ActionResponse.java (original)
+++ portals/pluto/trunk/portlet2-api/src/main/java/javax/portlet/ActionResponse.java Mon Feb  4 01:53:21 2008
@@ -1,3 +1,28 @@
+/*  Licensed to the Apache Software Foundation (ASF) under one
+ *  or more contributor license agreements.  See the NOTICE file
+ *  distributed with this work for additional information
+ *  regarding copyright ownership.  The ASF licenses this file
+ *  to you under the Apache License, Version 2.0 (the
+ *  "License"); you may not use this file except in compliance
+ *  with the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing,
+ *  software distributed under the License is distributed on an
+ *  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ *  KIND, either express or implied.  See the License for the
+ *  specific language governing permissions and limitations
+ *  under the License.
+ */
+/*
+ * NOTE: this source code is based on an early draft version of JSR 286 and not intended for product
+ * implementations. This file may change or vanish in the final version of the JSR 286 specification.
+ */
+/*
+ * This source code implements specifications defined by the Java
+ * Community Process. In order to remain compliant with the specification
+ * DO NOT add / change / or delete method signatures!
 /**
   * Copyright 2006 IBM Corporation.
   */