Re: Review Request 71029: Added Role::consumedQuota to the master.

[Benjamin Mahler <bm...@apache.org>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71029/
-----------------------------------------------------------

(Updated July 10, 2019, 1:18 a.m.)


Review request for mesos, Andrei Sekretenko and Meng Zhu.


Changes
-------

- Updated to correctly handle hierarchical accounting (by looping over all frameworks)
- Updated to avoid Resources arithemtic per mzhu's suggestion


Summary (updated)
-----------------

Added Role::consumedQuota to the master.


Bugs: MESOS-9871
    https://issues.apache.org/jira/browse/MESOS-9871


Repository: mesos


Description (updated)
-------

Quota consumption is computed as follows:

  Allocation + Unallocated Reservation ==
  Reservations + Unreserved Allocation

That is, reservations count towards quota regardless of whether
they're allocated. Allocation counts towards quota. Offered resources
*do not* count towards quota, this is to (1) provide stability of the
quota consumption metrics in the face of offers flowing in and out,
and (2) to ensure that we treat offers as rescindable and therefore
not yet "counting" towards quota. Also, if in the future schedulers
are offered more than their quota to improve their choices, counting
offered resources as consumed quota will be problematic.


Diffs (updated)
-----

  src/master/framework.cpp c35de2574ef683a9f397a957422fdbf8fa751313 
  src/master/master.hpp 23dafe746b6f9b3d70ad7220f54c4d49068b8af8 


Diff: https://reviews.apache.org/r/71029/diff/2/

Changes: https://reviews.apache.org/r/71029/diff/1-2/


Testing
-------

Added a test in a subsequent patch.


Thanks,

Benjamin Mahler