You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/09/14 20:11:20 UTC
[GitHub] [kafka] cadonna opened a new pull request #9286: KAFKA-10292: Set min.insync.replicas to 1 of __consumer_offsets
cadonna opened a new pull request #9286:
URL: https://github.com/apache/kafka/pull/9286
The test StreamsBrokerBounceTest.test_all_brokers_bounce() fails on
2.5 because in the last stage of the test there is only one broker
left and the offset commit cannot succeed because the
min.insync.replicas of __consumer_offsets is set to 2 and acks is
set to all. This causes a time out and extends the closing of the
Kafka Streams client to beyond the duration passed to the close
method of the client.
This affects especially the 2.5 branch since there Kafka Streams
commits offsets for each task, i.e., close() needs to wait for the
timeout for each task. In 2.6 and trunk the offset commit is done
per thread, so close() does only need to wait for one time out per
stream thread.
I opened this PR on trunk, since the test could also become
flaky on trunk and we want to avoid diverging system tests across
branches.
A more complete solution would be to improve the test by defining
a better success criteria.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on pull request #9286: KAFKA-10292: Set min.insync.replicas to 1 of __consumer_offsets
Posted by GitBox <gi...@apache.org>.
cadonna commented on pull request #9286:
URL: https://github.com/apache/kafka/pull/9286#issuecomment-692901008
Thanks a lot!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on pull request #9286: KAFKA-10292: Set min.insync.replicas to 1 of __consumer_offsets
Posted by GitBox <gi...@apache.org>.
cadonna commented on pull request #9286:
URL: https://github.com/apache/kafka/pull/9286#issuecomment-692287164
Call for review: @vvcephei @guozhangwang
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on pull request #9286: KAFKA-10292: Set min.insync.replicas to 1 of __consumer_offsets
Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #9286:
URL: https://github.com/apache/kafka/pull/9286#issuecomment-692886348
LGTM!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on pull request #9286: KAFKA-10292: Set min.insync.replicas to 1 of __consumer_offsets
Posted by GitBox <gi...@apache.org>.
cadonna commented on pull request #9286:
URL: https://github.com/apache/kafka/pull/9286#issuecomment-692893920
@guozhangwang, Thank you for merging! Could you please cherry-pick this PR to 2.6 and 2.5?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on pull request #9286: KAFKA-10292: Set min.insync.replicas to 1 of __consumer_offsets
Posted by GitBox <gi...@apache.org>.
cadonna commented on pull request #9286:
URL: https://github.com/apache/kafka/pull/9286#issuecomment-692643436
System test run for trunk:
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4166/
System test run for 2.6:
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4168/
System test run for 2.5:
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4167/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on pull request #9286: KAFKA-10292: Set min.insync.replicas to 1 of __consumer_offsets
Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #9286:
URL: https://github.com/apache/kafka/pull/9286#issuecomment-692897599
Yeah I've already cherry-picked to 2.6/2.5.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang merged pull request #9286: KAFKA-10292: Set min.insync.replicas to 1 of __consumer_offsets
Posted by GitBox <gi...@apache.org>.
guozhangwang merged pull request #9286:
URL: https://github.com/apache/kafka/pull/9286
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org