You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jackrabbit.apache.org by re...@apache.org on 2007/08/20 15:25:42 UTC
svn commit: r567695 - in
/jackrabbit/trunk/jackrabbit-jcr-tests/src/main/java/org/apache/jackrabbit/test/api:
AbstractImportXmlTest.java SerializationTest.java
Author: reschke
Date: Mon Aug 20 06:25:38 2007
New Revision: 567695
URL: http://svn.apache.org/viewvc?rev=567695&view=rev
Log:
JCR-1069: delete temporary files if test setup fails
Modified:
jackrabbit/trunk/jackrabbit-jcr-tests/src/main/java/org/apache/jackrabbit/test/api/AbstractImportXmlTest.java
jackrabbit/trunk/jackrabbit-jcr-tests/src/main/java/org/apache/jackrabbit/test/api/SerializationTest.java
Modified: jackrabbit/trunk/jackrabbit-jcr-tests/src/main/java/org/apache/jackrabbit/test/api/AbstractImportXmlTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-jcr-tests/src/main/java/org/apache/jackrabbit/test/api/AbstractImportXmlTest.java?rev=567695&r1=567694&r2=567695&view=diff
==============================================================================
--- jackrabbit/trunk/jackrabbit-jcr-tests/src/main/java/org/apache/jackrabbit/test/api/AbstractImportXmlTest.java (original)
+++ jackrabbit/trunk/jackrabbit-jcr-tests/src/main/java/org/apache/jackrabbit/test/api/AbstractImportXmlTest.java Mon Aug 20 06:25:38 2007
@@ -135,31 +135,43 @@
public void setUp() throws Exception {
super.setUp();
- dom = factory.newDocumentBuilder();
- file = File.createTempFile("docViewImportTest", ".xml");
- log.print("Tempfile: " + file.getAbsolutePath());
- session = superuser;
- workspace = session.getWorkspace();
- // create the target nodes for the imports
- target = testRoot + "/target";
- targetNode = createAncestors(target);
- refTarget = testRoot + "/refTarget";
- refTargetNode = createAncestors(refTarget);
-
- nsp = workspace.getNamespaceRegistry();
- ntManager = workspace.getNodeTypeManager();
-
- // construct a namespace not existing in the repository
- unusedPrefix = getUnusedPrefix();
- unusedURI = getUnusedURI();
- referenced = nodeName1;
- referencing = nodeName2;
- // test if jcr:uuid of mix:referenceable node type is respected
- respectMixRef = isMixRefRespected();
+ try {
+ dom = factory.newDocumentBuilder();
+ file = File.createTempFile("docViewImportTest", ".xml");
+ log.print("Tempfile: " + file.getAbsolutePath());
+ session = superuser;
+ workspace = session.getWorkspace();
+ // create the target nodes for the imports
+ target = testRoot + "/target";
+ targetNode = createAncestors(target);
+ refTarget = testRoot + "/refTarget";
+ refTargetNode = createAncestors(refTarget);
+
+ nsp = workspace.getNamespaceRegistry();
+ ntManager = workspace.getNodeTypeManager();
+
+ // construct a namespace not existing in the repository
+ unusedPrefix = getUnusedPrefix();
+ unusedURI = getUnusedURI();
+ referenced = nodeName1;
+ referencing = nodeName2;
+ // test if jcr:uuid of mix:referenceable node type is respected
+ respectMixRef = isMixRefRespected();
+ }
+ catch (Exception ex) {
+ if (file != null) {
+ file.delete();
+ file = null;
+ }
+ throw (ex);
+ }
}
public void tearDown() throws Exception {
- file.delete();
+ if (file != null) {
+ file.delete();
+ file = null;
+ }
super.tearDown();
}
Modified: jackrabbit/trunk/jackrabbit-jcr-tests/src/main/java/org/apache/jackrabbit/test/api/SerializationTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-jcr-tests/src/main/java/org/apache/jackrabbit/test/api/SerializationTest.java?rev=567695&r1=567694&r2=567695&view=diff
==============================================================================
--- jackrabbit/trunk/jackrabbit-jcr-tests/src/main/java/org/apache/jackrabbit/test/api/SerializationTest.java (original)
+++ jackrabbit/trunk/jackrabbit-jcr-tests/src/main/java/org/apache/jackrabbit/test/api/SerializationTest.java Mon Aug 20 06:25:38 2007
@@ -75,18 +75,30 @@
public void setUp() throws RepositoryException, Exception {
super.setUp();
- session = superuser;
- workspace = session.getWorkspace();
- file = File.createTempFile("test", ".xml");
- log.print("Tempfile: " + file.getAbsolutePath());
-
- SerializationContext sc = new SerializationContext(this);
- treeComparator = new TreeComparator(sc, session);
- treeComparator.createComplexTree(treeComparator.WORKSPACE);
+ try {
+ session = superuser;
+ workspace = session.getWorkspace();
+ file = File.createTempFile("serializationTest", ".xml");
+ log.print("Tempfile: " + file.getAbsolutePath());
+
+ SerializationContext sc = new SerializationContext(this);
+ treeComparator = new TreeComparator(sc, session);
+ treeComparator.createComplexTree(treeComparator.WORKSPACE);
+ }
+ catch (Exception ex) {
+ if (file != null) {
+ file.delete();
+ file = null;
+ }
+ throw (ex);
+ }
}
public void tearDown() throws Exception {
- file.delete();
+ if (file != null) {
+ file.delete();
+ file = null;
+ }
if (session != null && session.isLive()) {
session.logout();
}