You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/08/31 13:14:46 UTC
[GitHub] [ignite] J-Bakuli opened a new pull request, #10230: IGNITE-17541 Create get and set methods with serverExceptionStackTrac…
J-Bakuli opened a new pull request, #10230:
URL: https://github.com/apache/ignite/pull/10230
[IGNITE-13389](https://issues.apache.org/jira/browse/IGNITE-13389) introduces ThinClientConfiguration#sendServerExceptionStackTraceToClient(), but name of the method does not allow to set up this option in XML configuration, because Spring expects "set" prefix for setters.
https://github.com/apache/ignite/blob/4a6ff6f4aa1994b39bf40cc8ad80ac5df704d569/modules/core/src/main/java/org/apache/ignite/configuration/ThinClientConfiguration.java#L107
Possible workarounds:
1. Add extra ThinClientConfiguration bean with necessary parameters
2. Set up thinClientConfiguration by means of SpEL
Although there several ways out of the situation it is more convenient to set up this property directly and use 'set' and 'get' prefixes to setter and getter methods thus I have added 'set' prefix to the sendServerExceptionStackTraceToClient() below:
1. ThinClientConfiguration.class
https://github.com/apache/ignite/blob/4a6ff6f4aa1994b39bf40cc8ad80ac5df704d569/modules/core/src/main/java/org/apache/ignite/configuration/ThinClientConfiguration.java#L107
2. PlatformConfigurationUtils.class in readClientConnectorConfiguration()
https://github.com/apache/ignite/blob/4a6ff6f4aa1994b39bf40cc8ad80ac5df704d569/modules/core/src/main/java/org/apache/ignite/internal/processors/platform/utils/PlatformConfigurationUtils.java#L1963
Although there are some workarounds it would be more convenient to set up this property directly.
We should add "set" and "get" prefix to setter and getter methods respectively or add extra methods with such prefixes from the point of possible compatibility issues (see [IGNITE-16549](https://issues.apache.org/jira/browse/IGNITE-16549)).
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] J-Bakuli commented on a diff in pull request #10230: IGNITE-17541 Create get and set methods with serverExceptionStackTrac…
Posted by GitBox <gi...@apache.org>.
J-Bakuli commented on code in PR #10230:
URL: https://github.com/apache/ignite/pull/10230#discussion_r965685951
##########
modules/core/src/main/java/org/apache/ignite/configuration/ThinClientConfiguration.java:
##########
@@ -48,10 +56,11 @@ public ThinClientConfiguration() {
}
/**
- * Creates thin-client configuration by copying all properties from given configuration.
- *
* @param cfg Configuration to copy.
+ * Creates thin-client configuration by copying all properties from given configuration.
+ * @deprecated
*/
+ @Deprecated
Review Comment:
It used the deprecated field sendServerExcStackTraceToClient.
After your comments I have removed the Deprecated mark so this constructor is no longer deprecated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] alex-plekhanov commented on a diff in pull request #10230: IGNITE-17541 Create get and set methods with serverExceptionStackTrac…
Posted by GitBox <gi...@apache.org>.
alex-plekhanov commented on code in PR #10230:
URL: https://github.com/apache/ignite/pull/10230#discussion_r965761254
##########
modules/core/src/main/java/org/apache/ignite/configuration/ThinClientConfiguration.java:
##########
@@ -103,22 +112,45 @@ public ThinClientConfiguration setMaxActiveComputeTasksPerConnection(int maxActi
/**
* @return If {@code true} sends a server exception stack to the client side.
+ * @deprecated please now use new method getServerExceptionStackTraceToClient().
*/
+ @Deprecated
public boolean sendServerExceptionStackTraceToClient() {
return sendServerExcStackTraceToClient;
}
/**
* @param sendServerExcStackTraceToClient If {@code true} sends a server exception stack to the client side.
* @return {@code this} for chaining.
+ * @deprecated please now use new method setServerExceptionStackTraceToClient().
*/
+ @Deprecated
public ThinClientConfiguration sendServerExceptionStackTraceToClient(boolean sendServerExcStackTraceToClient) {
this.sendServerExcStackTraceToClient = sendServerExcStackTraceToClient;
return this;
}
- /** {@inheritDoc} */
+ /**
+ * @return If {@code true} gets a server exception stack that is to be sent to the client side.
+ */
+ public boolean getServerExceptionStackTraceToClient() {
+ return serverExcStackTraceToClient;
+ }
+
+ /**
+ * @param serverExcStackTraceToClient if {@code true} sets a server exception stack that is to be sent to the client side.
+ * @return {@code this} for chaining.
+ */
+ public ThinClientConfiguration setServerExceptionStackTraceToClient(boolean serverExcStackTraceToClient) {
Review Comment:
Javadoc for this parameter of the old method looks better to me, but it's up to you.
Also, the first word of the javadoc should start with the upper case letter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] asfgit closed pull request #10230: IGNITE-17541 Create get and set methods with serverExceptionStackTrac…
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #10230: IGNITE-17541 Create get and set methods with serverExceptionStackTrac…
URL: https://github.com/apache/ignite/pull/10230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] J-Bakuli commented on a diff in pull request #10230: IGNITE-17541 Create get and set methods with serverExceptionStackTrac…
Posted by GitBox <gi...@apache.org>.
J-Bakuli commented on code in PR #10230:
URL: https://github.com/apache/ignite/pull/10230#discussion_r967017013
##########
modules/core/src/main/java/org/apache/ignite/configuration/ThinClientConfiguration.java:
##########
@@ -103,21 +103,42 @@ public ThinClientConfiguration setMaxActiveComputeTasksPerConnection(int maxActi
/**
* @return If {@code true} sends a server exception stack to the client side.
+ * @deprecated Use {@link #getServerExceptionStackTraceToClient()} instead.
*/
+ @Deprecated
public boolean sendServerExceptionStackTraceToClient() {
return sendServerExcStackTraceToClient;
}
/**
* @param sendServerExcStackTraceToClient If {@code true} sends a server exception stack to the client side.
* @return {@code this} for chaining.
+ * @deprecated Use {@link #setServerToClientExceptionStackTraceSending(boolean)} instead.
*/
+ @Deprecated
public ThinClientConfiguration sendServerExceptionStackTraceToClient(boolean sendServerExcStackTraceToClient) {
this.sendServerExcStackTraceToClient = sendServerExcStackTraceToClient;
return this;
}
+ /**
+ * @return If {@code true} gets a server exception stack that is to be sent to the client side.
+ */
+ public boolean getServerExceptionStackTraceToClient() {
Review Comment:
Thank you, I will rename the method to be the same as for setter and correct Javadoc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] J-Bakuli commented on a diff in pull request #10230: IGNITE-17541 Create get and set methods with serverExceptionStackTrac…
Posted by GitBox <gi...@apache.org>.
J-Bakuli commented on code in PR #10230:
URL: https://github.com/apache/ignite/pull/10230#discussion_r965680946
##########
modules/core/src/main/java/org/apache/ignite/configuration/ThinClientConfiguration.java:
##########
@@ -103,22 +112,45 @@ public ThinClientConfiguration setMaxActiveComputeTasksPerConnection(int maxActi
/**
* @return If {@code true} sends a server exception stack to the client side.
+ * @deprecated please now use new method getServerExceptionStackTraceToClient().
*/
+ @Deprecated
public boolean sendServerExceptionStackTraceToClient() {
return sendServerExcStackTraceToClient;
}
/**
* @param sendServerExcStackTraceToClient If {@code true} sends a server exception stack to the client side.
* @return {@code this} for chaining.
+ * @deprecated please now use new method setServerExceptionStackTraceToClient().
*/
+ @Deprecated
public ThinClientConfiguration sendServerExceptionStackTraceToClient(boolean sendServerExcStackTraceToClient) {
this.sendServerExcStackTraceToClient = sendServerExcStackTraceToClient;
return this;
}
- /** {@inheritDoc} */
+ /**
+ * @return If {@code true} gets a server exception stack that is to be sent to the client side.
+ */
+ public boolean getServerExceptionStackTraceToClient() {
+ return serverExcStackTraceToClient;
+ }
+
+ /**
+ * @param serverExcStackTraceToClient if {@code true} sets a server exception stack that is to be sent to the client side.
+ * @return {@code this} for chaining.
+ */
+ public ThinClientConfiguration setServerExceptionStackTraceToClient(boolean serverExcStackTraceToClient) {
Review Comment:
Agree, I have changed the method name as per your recommendation above.
Java doc then is "@param sendStackTrace if {@code true} sets a server to client exception stack trace sending."
Do you agree?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] J-Bakuli commented on pull request #10230: IGNITE-17541 Create get and set methods with serverExceptionStackTrac…
Posted by GitBox <gi...@apache.org>.
J-Bakuli commented on PR #10230:
URL: https://github.com/apache/ignite/pull/10230#issuecomment-1243286662
@NSAmelchev, could you please review the changes?
They are almost fully checked by the previous reviewer.
Green visa https://mtcga.gridgain.com/prs.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] J-Bakuli commented on a diff in pull request #10230: IGNITE-17541 Create get and set methods with serverExceptionStackTrac…
Posted by GitBox <gi...@apache.org>.
J-Bakuli commented on code in PR #10230:
URL: https://github.com/apache/ignite/pull/10230#discussion_r965694603
##########
modules/core/src/main/java/org/apache/ignite/configuration/ThinClientConfiguration.java:
##########
@@ -37,9 +37,17 @@ public class ThinClientConfiguration {
/** Active compute tasks per connection limit. */
private int maxActiveComputeTasksPerConn = DFLT_MAX_ACTIVE_COMPUTE_TASKS_PER_CONNECTION;
- /** If {@code true} sends a server exception stack trace to the client side. */
+ /**
+ * @see new field serverExcStackTraceToClient.
+ * If {@code true} sends a server exception stack trace to the client side.
+ * @deprecated please now use new field serverExcStackTraceToClientbecause.
+ */
+ @Deprecated
private boolean sendServerExcStackTraceToClient;
+ /** If {@code true} a server exception stack trace is sent to the client side. */
+ private boolean serverExcStackTraceToClient;
Review Comment:
Thank you, I have changed the code to be in line with your comments above.
That new field was added to be inserted into another constructor that is to be used later when new pull requests remove deprecated fields / methods from the code completely. That was my intention.
This PR and the ticket is to add set/get methods w/o overcomplication so agree with you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] J-Bakuli commented on pull request #10230: IGNITE-17541 Create get and set methods with serverExceptionStackTrac…
Posted by GitBox <gi...@apache.org>.
J-Bakuli commented on PR #10230:
URL: https://github.com/apache/ignite/pull/10230#issuecomment-1236637635
@alex-plekhanov, could you please review my changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] alex-plekhanov commented on a diff in pull request #10230: IGNITE-17541 Create get and set methods with serverExceptionStackTrac…
Posted by GitBox <gi...@apache.org>.
alex-plekhanov commented on code in PR #10230:
URL: https://github.com/apache/ignite/pull/10230#discussion_r966708668
##########
modules/core/src/main/java/org/apache/ignite/configuration/ThinClientConfiguration.java:
##########
@@ -103,21 +103,42 @@ public ThinClientConfiguration setMaxActiveComputeTasksPerConnection(int maxActi
/**
* @return If {@code true} sends a server exception stack to the client side.
+ * @deprecated Use {@link #getServerExceptionStackTraceToClient()} instead.
*/
+ @Deprecated
public boolean sendServerExceptionStackTraceToClient() {
return sendServerExcStackTraceToClient;
}
/**
* @param sendServerExcStackTraceToClient If {@code true} sends a server exception stack to the client side.
* @return {@code this} for chaining.
+ * @deprecated Use {@link #setServerToClientExceptionStackTraceSending(boolean)} instead.
*/
+ @Deprecated
public ThinClientConfiguration sendServerExceptionStackTraceToClient(boolean sendServerExcStackTraceToClient) {
this.sendServerExcStackTraceToClient = sendServerExcStackTraceToClient;
return this;
}
+ /**
+ * @return If {@code true} gets a server exception stack that is to be sent to the client side.
+ */
+ public boolean getServerExceptionStackTraceToClient() {
Review Comment:
The name should be the same as for setter. Javadoc also must be fixed.
BTW do we really need getter with `get` prefix? We need setter to set value in spring XML configuration, but getter is not used here, pehaps the new getter is redundant?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] J-Bakuli commented on a diff in pull request #10230: IGNITE-17541 Create get and set methods with serverExceptionStackTrac…
Posted by GitBox <gi...@apache.org>.
J-Bakuli commented on code in PR #10230:
URL: https://github.com/apache/ignite/pull/10230#discussion_r967017013
##########
modules/core/src/main/java/org/apache/ignite/configuration/ThinClientConfiguration.java:
##########
@@ -103,21 +103,42 @@ public ThinClientConfiguration setMaxActiveComputeTasksPerConnection(int maxActi
/**
* @return If {@code true} sends a server exception stack to the client side.
+ * @deprecated Use {@link #getServerExceptionStackTraceToClient()} instead.
*/
+ @Deprecated
public boolean sendServerExceptionStackTraceToClient() {
return sendServerExcStackTraceToClient;
}
/**
* @param sendServerExcStackTraceToClient If {@code true} sends a server exception stack to the client side.
* @return {@code this} for chaining.
+ * @deprecated Use {@link #setServerToClientExceptionStackTraceSending(boolean)} instead.
*/
+ @Deprecated
public ThinClientConfiguration sendServerExceptionStackTraceToClient(boolean sendServerExcStackTraceToClient) {
this.sendServerExcStackTraceToClient = sendServerExcStackTraceToClient;
return this;
}
+ /**
+ * @return If {@code true} gets a server exception stack that is to be sent to the client side.
+ */
+ public boolean getServerExceptionStackTraceToClient() {
Review Comment:
I have deleted new getter, removed deprecation from the old one. So now additions to this PR are new setter and deprecation of the old setter, that's all.
Answering your question, the new getter is redundant as we can leave without it as per now that is why it can be deleted as well as the deprecation can be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] J-Bakuli commented on a diff in pull request #10230: IGNITE-17541 Create get and set methods with serverExceptionStackTrac…
Posted by GitBox <gi...@apache.org>.
J-Bakuli commented on code in PR #10230:
URL: https://github.com/apache/ignite/pull/10230#discussion_r967017013
##########
modules/core/src/main/java/org/apache/ignite/configuration/ThinClientConfiguration.java:
##########
@@ -103,21 +103,42 @@ public ThinClientConfiguration setMaxActiveComputeTasksPerConnection(int maxActi
/**
* @return If {@code true} sends a server exception stack to the client side.
+ * @deprecated Use {@link #getServerExceptionStackTraceToClient()} instead.
*/
+ @Deprecated
public boolean sendServerExceptionStackTraceToClient() {
return sendServerExcStackTraceToClient;
}
/**
* @param sendServerExcStackTraceToClient If {@code true} sends a server exception stack to the client side.
* @return {@code this} for chaining.
+ * @deprecated Use {@link #setServerToClientExceptionStackTraceSending(boolean)} instead.
*/
+ @Deprecated
public ThinClientConfiguration sendServerExceptionStackTraceToClient(boolean sendServerExcStackTraceToClient) {
this.sendServerExcStackTraceToClient = sendServerExcStackTraceToClient;
return this;
}
+ /**
+ * @return If {@code true} gets a server exception stack that is to be sent to the client side.
+ */
+ public boolean getServerExceptionStackTraceToClient() {
Review Comment:
I have deleted the new getter, removed deprecation from the old one. So now additions to this PR are new setter and deprecation of the old setter, that's all.
Answering your question, the new getter is redundant as we can leave without it as per now that is why it can be deleted as well as the deprecation can be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] alex-plekhanov commented on a diff in pull request #10230: IGNITE-17541 Create get and set methods with serverExceptionStackTrac…
Posted by GitBox <gi...@apache.org>.
alex-plekhanov commented on code in PR #10230:
URL: https://github.com/apache/ignite/pull/10230#discussion_r964617045
##########
modules/core/src/main/java/org/apache/ignite/configuration/ThinClientConfiguration.java:
##########
@@ -103,22 +112,45 @@ public ThinClientConfiguration setMaxActiveComputeTasksPerConnection(int maxActi
/**
* @return If {@code true} sends a server exception stack to the client side.
+ * @deprecated please now use new method getServerExceptionStackTraceToClient().
Review Comment:
`@deprecated Use {@link #getServerExceptionStackTraceToClient} instead.`
##########
modules/core/src/main/java/org/apache/ignite/configuration/ThinClientConfiguration.java:
##########
@@ -103,22 +112,45 @@ public ThinClientConfiguration setMaxActiveComputeTasksPerConnection(int maxActi
/**
* @return If {@code true} sends a server exception stack to the client side.
+ * @deprecated please now use new method getServerExceptionStackTraceToClient().
*/
+ @Deprecated
public boolean sendServerExceptionStackTraceToClient() {
return sendServerExcStackTraceToClient;
}
/**
* @param sendServerExcStackTraceToClient If {@code true} sends a server exception stack to the client side.
* @return {@code this} for chaining.
+ * @deprecated please now use new method setServerExceptionStackTraceToClient().
*/
+ @Deprecated
public ThinClientConfiguration sendServerExceptionStackTraceToClient(boolean sendServerExcStackTraceToClient) {
this.sendServerExcStackTraceToClient = sendServerExcStackTraceToClient;
return this;
}
- /** {@inheritDoc} */
+ /**
+ * @return If {@code true} gets a server exception stack that is to be sent to the client side.
+ */
+ public boolean getServerExceptionStackTraceToClient() {
+ return serverExcStackTraceToClient;
+ }
+
+ /**
+ * @param serverExcStackTraceToClient if {@code true} sets a server exception stack that is to be sent to the client side.
+ * @return {@code this} for chaining.
+ */
+ public ThinClientConfiguration setServerExceptionStackTraceToClient(boolean serverExcStackTraceToClient) {
Review Comment:
Is not clear from the method's name what exactly this method set (javadoc also confusing). How about `setServerToClientExceptionStackTraceSending(boolean sendStackTrace)`?
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/odbc/ClientListenerProcessor.java:
##########
@@ -571,7 +571,7 @@ public boolean sendServerExceptionStackTraceToClient() {
Boolean send = distrThinCfg.sendServerExceptionStackTraceToClient();
return send == null ?
- ctx.config().getClientConnectorConfiguration().getThinClientConfiguration().sendServerExceptionStackTraceToClient() : send;
+ ctx.config().getClientConnectorConfiguration().getThinClientConfiguration().sendServerExceptionStackTraceToClient() : send;
Review Comment:
Looks like redundant change
##########
modules/core/src/main/java/org/apache/ignite/configuration/ThinClientConfiguration.java:
##########
@@ -103,22 +112,45 @@ public ThinClientConfiguration setMaxActiveComputeTasksPerConnection(int maxActi
/**
* @return If {@code true} sends a server exception stack to the client side.
+ * @deprecated please now use new method getServerExceptionStackTraceToClient().
*/
+ @Deprecated
public boolean sendServerExceptionStackTraceToClient() {
return sendServerExcStackTraceToClient;
}
/**
* @param sendServerExcStackTraceToClient If {@code true} sends a server exception stack to the client side.
* @return {@code this} for chaining.
+ * @deprecated please now use new method setServerExceptionStackTraceToClient().
Review Comment:
`@deprecated Use {@link #setServerExceptionStackTraceToClient} instead.`
##########
modules/core/src/main/java/org/apache/ignite/configuration/ThinClientConfiguration.java:
##########
@@ -103,22 +112,45 @@ public ThinClientConfiguration setMaxActiveComputeTasksPerConnection(int maxActi
/**
* @return If {@code true} sends a server exception stack to the client side.
+ * @deprecated please now use new method getServerExceptionStackTraceToClient().
*/
+ @Deprecated
public boolean sendServerExceptionStackTraceToClient() {
return sendServerExcStackTraceToClient;
}
/**
* @param sendServerExcStackTraceToClient If {@code true} sends a server exception stack to the client side.
* @return {@code this} for chaining.
+ * @deprecated please now use new method setServerExceptionStackTraceToClient().
*/
+ @Deprecated
public ThinClientConfiguration sendServerExceptionStackTraceToClient(boolean sendServerExcStackTraceToClient) {
this.sendServerExcStackTraceToClient = sendServerExcStackTraceToClient;
return this;
}
- /** {@inheritDoc} */
+ /**
+ * @return If {@code true} gets a server exception stack that is to be sent to the client side.
+ */
+ public boolean getServerExceptionStackTraceToClient() {
+ return serverExcStackTraceToClient;
+ }
+
+ /**
+ * @param serverExcStackTraceToClient if {@code true} sets a server exception stack that is to be sent to the client side.
+ * @return {@code this} for chaining.
+ */
+ public ThinClientConfiguration setServerExceptionStackTraceToClient(boolean serverExcStackTraceToClient) {
+ this.serverExcStackTraceToClient = serverExcStackTraceToClient;
+
+ return this;
+ }
+
+ /**
+ * {@inheritDoc}
Review Comment:
Redundant change, let's keep one-line javadoc.
##########
modules/core/src/main/java/org/apache/ignite/configuration/ThinClientConfiguration.java:
##########
@@ -37,9 +37,17 @@ public class ThinClientConfiguration {
/** Active compute tasks per connection limit. */
private int maxActiveComputeTasksPerConn = DFLT_MAX_ACTIVE_COMPUTE_TASKS_PER_CONNECTION;
- /** If {@code true} sends a server exception stack trace to the client side. */
+ /**
+ * @see new field serverExcStackTraceToClient.
+ * If {@code true} sends a server exception stack trace to the client side.
+ * @deprecated please now use new field serverExcStackTraceToClientbecause.
+ */
+ @Deprecated
private boolean sendServerExcStackTraceToClient;
+ /** If {@code true} a server exception stack trace is sent to the client side. */
+ private boolean serverExcStackTraceToClient;
Review Comment:
Why do we need the new field? Why can't we create setter and getter over the old one? Currently this new field is not used inside Ignite, except getter and setter, which are also not used. So pull-request is effectively no-op. There should be some tests added to avoid such errors.
##########
modules/core/src/main/java/org/apache/ignite/configuration/ThinClientConfiguration.java:
##########
@@ -48,10 +56,11 @@ public ThinClientConfiguration() {
}
/**
- * Creates thin-client configuration by copying all properties from given configuration.
- *
* @param cfg Configuration to copy.
+ * Creates thin-client configuration by copying all properties from given configuration.
+ * @deprecated
*/
+ @Deprecated
Review Comment:
Why this constructor was deprecated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org