[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4739: Allow creating snapshot from VM snapshot

[GitBox <gi...@apache.org>]

sureshanaparti commented on a change in pull request #4739:
URL: https://github.com/apache/cloudstack/pull/4739#discussion_r615791884



##########
File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
##########
@@ -2692,7 +2692,7 @@ public Snapshot allocSnapshot(Long volumeId, Long policyId, String snapshotName,
             throw new InvalidParameterValueException("VolumeId: " + volumeId + " please attach this volume to a VM before create snapshot for it");
         }
 
-        return snapshotMgr.allocSnapshot(volumeId, policyId, snapshotName, locationType);
+        return snapshotMgr.allocSnapshot(volumeId, policyId, snapshotName, locationType, null);

Review comment:
       @ravening null here means true or false ? if false, you can keep the old method.
   
   ```suggestion
           return snapshotMgr.allocSnapshot(volumeId, policyId, snapshotName, locationType, null);
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org