You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/30 18:34:49 UTC

[GitHub] [airflow] ashb commented on a change in pull request #13922: Fix read allows dag trigger bug

ashb commented on a change in pull request #13922:
URL: https://github.com/apache/airflow/pull/13922#discussion_r567296006



##########
File path: airflow/migrations/versions/2c6edca13270_resource_based_permissions.py
##########
@@ -161,7 +161,7 @@
         (permissions.ACTION_CAN_READ, permissions.RESOURCE_TASK_INSTANCE),
     ],
     ("Airflow", "can_trigger"): [
-        (permissions.ACTION_CAN_READ, permissions.RESOURCE_DAG),
+        (permissions.ACTION_CAN_EDIT, permissions.RESOURCE_DAG),

Review comment:
       Changing the migration won't affect anyone who has already upgrade to 2.0.0 - do we need a new migration to fix this up?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org