You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/02/20 03:10:18 UTC
[jira] [Commented] (CB-10263) Fix splashscreen plugin filenames for
Asset Catalog
[ https://issues.apache.org/jira/browse/CB-10263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15155302#comment-15155302 ]
ASF GitHub Bot commented on CB-10263:
-------------------------------------
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/69#issuecomment-186485912
@daserge Have you tested this and verified it's working? I have the splashscreen plugin v3.2.0, and have manually converted my existing `cordova-ios@4.0.1` project to using the asset catalogs. The splashscreen plugin appears to be looking for the `Default` filename instead of `LaunchImage`.
I do not have a `UILaunchImageFile` key in my plist anymore (and note the template does not either). Isn't the logic here backwards -- if the `UILaunchImageFile` key exists then that's the filename to use, otherwise it should use `LaunchImage` and assume it's in an asset catalog? Or will that break compatibility for folks who assume the default filenames are used without adding it to the plist.
> Fix splashscreen plugin filenames for Asset Catalog
> ---------------------------------------------------
>
> Key: CB-10263
> URL: https://issues.apache.org/jira/browse/CB-10263
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin SplashScreen
> Environment: ios@4.0.1
> Reporter: Sergey Shakhnazarov
> Assignee: Sergey Shakhnazarov
> Priority: Critical
> Labels: ios
>
> {code}
> cordova create test
> cd test
> cordova platform add ios@4
> cordova plugin add https://github.com/apache/cordova-plugin-splashscreen
> {code}
> {code}
> // add to config.xml:
> <platform name="ios">
> <allow-intent href="itms:*" />
> <allow-intent href="itms-apps:*" />
> <splash src="res/screen/ios/Default~iphone.png" width="320" height="480"/>
> <splash src="res/screen/ios/Default@2x~iphone.png" width="640" height="960"/>
> <splash src="res/screen/ios/Default-Portrait~ipad.png" width="768" height="1024"/>
> <splash src="res/screen/ios/Default-Portrait@2x~ipad.png" width="1536" height="2048"/>
> <splash src="res/screen/ios/Default-Landscape~ipad.png" width="1024" height="768"/>
> <splash src="res/screen/ios/Default-Landscape@2x~ipad.png" width="2048" height="1536"/>
> <splash src="res/screen/ios/Default-568h@2x~iphone.png" width="640" height="1136"/>
> <splash src="res/screen/ios/Default-667h.png" width="750" height="1334"/>
> <splash src="res/screen/ios/Default-736h.png" width="1242" height="2208"/>
> <splash src="res/screen/ios/Default-Landscape-736h.png" width="2208" height="1242"/>
> <preference name="AutoHideSplashScreen" value="false" />
> <preference name="FadeSplashScreen" value="true"/>
> <preference name="FadeSplashScreenDuration" value="1500"/>
> </platform>
> <preference name="SplashScreenDelay" value="2000" />
> <preference name="ShowSplashScreenSpinner" value="true"/>
> <preference name="Orientation" value="all"/>
> {code}
> {code}
> // add to index.js deviceready event:
> setTimeout(navigator.splashscreen.hide, 3000);
> {code}
> {code}
> cordova emulate ios --target=iPhone-6-Plus
> {code}
> Splash screen will be shown briefly and after that the image will disappear leaving only the spinner.
> The following message will be logged out:
> *WARNING: The splashscreen image named LaunchImage-736h was not found*
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org