You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/10/16 13:04:01 UTC
[GitHub] [lucene-solr] dsmiley opened a new pull request #1993: .gitignore clean up
dsmiley opened a new pull request #1993:
URL: https://github.com/apache/lucene-solr/pull/1993
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] madrob commented on a change in pull request #1993: .gitignore clean up
Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #1993:
URL: https://github.com/apache/lucene-solr/pull/1993#discussion_r508593777
##########
File path: .gitignore
##########
@@ -1,42 +1,33 @@
-# .
-/eclipse-build
-/maven-build
-/classes
-build
-/idea-build
-dist
-lib
-test-lib
-/*~
-/build.properties
-/.idea
-lucene/**/*.iml
-parent.iml
-*.ipr
-*.iws
-/*.iml
-.project
-.classpath
-.settings
-/.caches
-/prj.el
-bin
-/bin
-/bin.*
-pom.xml
-/nbproject
-/nb-build
-.pydevproject
-__pycache__
-/dev-tools/scripts/scripts.iml
-.DS_Store
+### At the root
+
+/.idea/
+# Ignore the generated local settings file.
+/gradle.properties
+
+/prj.el # TODO?
+
+# Eclipse
+/.project
+/.classpath
+/.settings/
+
+### Any dir
-build/
.gradle/
-.idea/
+build/
-# Ignore the generated local settings file.
-gradle.properties
+# macOS
+.DS_Store
+
+# Eclipse Gradle oddity
+**/bin/default/
Review comment:
Move this to the other Eclipse section?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1993: .gitignore clean up
Posted by GitBox <gi...@apache.org>.
dsmiley commented on a change in pull request #1993:
URL: https://github.com/apache/lucene-solr/pull/1993#discussion_r508972018
##########
File path: .gitignore
##########
@@ -1,42 +1,33 @@
-# .
-/eclipse-build
-/maven-build
-/classes
-build
-/idea-build
-dist
-lib
-test-lib
-/*~
-/build.properties
-/.idea
-lucene/**/*.iml
-parent.iml
-*.ipr
-*.iws
-/*.iml
-.project
-.classpath
-.settings
-/.caches
-/prj.el
-bin
-/bin
-/bin.*
-pom.xml
-/nbproject
-/nb-build
-.pydevproject
-__pycache__
-/dev-tools/scripts/scripts.iml
-.DS_Store
+### At the root
+
+/.idea/
+# Ignore the generated local settings file.
+/gradle.properties
+
+/prj.el # TODO?
+
+# Eclipse
+/.project
+/.classpath
+/.settings/
+
+### Any dir
-build/
.gradle/
-.idea/
+build/
-# Ignore the generated local settings file.
-gradle.properties
+# macOS
+.DS_Store
+
+# Eclipse Gradle oddity
+**/bin/default/
Review comment:
What you refer to as "the other Eclipse section" is in a higher level "at the root", and this rule here is not at the root, it's at any directory. That said, I suppose I should toss out that "at the root" label as it's better to put all these eclipse rules together.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] msokolov commented on pull request #1993: .gitignore clean up
Posted by GitBox <gi...@apache.org>.
msokolov commented on pull request #1993:
URL: https://github.com/apache/lucene-solr/pull/1993#issuecomment-715478148
> @msokolov you added .#* -- what comment should I use in this file to explain what this is?
It's more cruft emacs sometimes leaves behind _ I think in this case it's an autosave backup file left if you exited while editing. On second thought, we probably don't need to list this here - it shouldn't arise as a normal thing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dsmiley commented on pull request #1993: .gitignore clean up
Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #1993:
URL: https://github.com/apache/lucene-solr/pull/1993#issuecomment-715309491
@msokolov you added `.#*` -- what comment should I use in this file to explain what this is?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dsmiley merged pull request #1993: .gitignore clean up
Posted by GitBox <gi...@apache.org>.
dsmiley merged pull request #1993:
URL: https://github.com/apache/lucene-solr/pull/1993
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] madrob commented on a change in pull request #1993: .gitignore clean up
Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #1993:
URL: https://github.com/apache/lucene-solr/pull/1993#discussion_r509401433
##########
File path: .gitignore
##########
@@ -1,42 +1,33 @@
-# .
-/eclipse-build
-/maven-build
-/classes
-build
-/idea-build
-dist
-lib
-test-lib
-/*~
-/build.properties
-/.idea
-lucene/**/*.iml
-parent.iml
-*.ipr
-*.iws
-/*.iml
-.project
-.classpath
-.settings
-/.caches
-/prj.el
-bin
-/bin
-/bin.*
-pom.xml
-/nbproject
-/nb-build
-.pydevproject
-__pycache__
-/dev-tools/scripts/scripts.iml
-.DS_Store
+### At the root
+
+/.idea/
+# Ignore the generated local settings file.
+/gradle.properties
+
+/prj.el # TODO?
+
+# Eclipse
+/.project
+/.classpath
+/.settings/
+
+### Any dir
-build/
.gradle/
-.idea/
+build/
-# Ignore the generated local settings file.
-gradle.properties
+# macOS
+.DS_Store
+
+# Eclipse Gradle oddity
+**/bin/default/
Review comment:
I don't use Eclipse so this doesn't really affect me much, but I think it's easier to have contiguous sections I can ignore instead of it being piecemeal throughout the file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] msokolov commented on a change in pull request #1993: .gitignore clean up
Posted by GitBox <gi...@apache.org>.
msokolov commented on a change in pull request #1993:
URL: https://github.com/apache/lucene-solr/pull/1993#discussion_r506427822
##########
File path: .gitignore
##########
@@ -1,42 +1,30 @@
-# .
-/eclipse-build
-/maven-build
-/classes
-build
-/idea-build
-dist
-lib
-test-lib
-/*~
-/build.properties
-/.idea
-lucene/**/*.iml
-parent.iml
-*.ipr
-*.iws
-/*.iml
-.project
-.classpath
-.settings
-/.caches
-/prj.el
-bin
-/bin
-/bin.*
-pom.xml
-/nbproject
-/nb-build
-.pydevproject
-__pycache__
-/dev-tools/scripts/scripts.iml
-.DS_Store
+### At the root
+
+/.gradle/
+/.idea/
+# Ignore the generated local settings file.
+/gradle.properties
+/*~ # TODO?
Review comment:
This should be plain `*~` not rooted at `/` - it's for emacs backup files
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dsmiley commented on pull request #1993: .gitignore clean up
Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #1993:
URL: https://github.com/apache/lucene-solr/pull/1993#issuecomment-715572444
Finally; I think it's ready. Much simpler file than before and more organized. Outdated items from the 8x branch are gone.
I'll merge Monday unless I get an approving review sooner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dweiss commented on a change in pull request #1993: .gitignore clean up
Posted by GitBox <gi...@apache.org>.
dweiss commented on a change in pull request #1993:
URL: https://github.com/apache/lucene-solr/pull/1993#discussion_r511344950
##########
File path: .gitignore
##########
@@ -1,43 +1,27 @@
-# .
-/eclipse-build
-/maven-build
-/classes
-build
-/idea-build
-dist
-lib
-test-lib
-*~
-.#*
-/build.properties
-/.idea
-lucene/**/*.iml
-parent.iml
-*.ipr
-*.iws
-/*.iml
-.project
-.classpath
-.settings
-/.caches
-/prj.el
-bin
-/bin
-/bin.*
-pom.xml
-/nbproject
-/nb-build
-.pydevproject
-__pycache__
-/dev-tools/scripts/scripts.iml
-.DS_Store
-
-build/
+# Gradle
+# Ignore the generated local settings file.
+/gradle.properties
.gradle/
-.idea/
+build/
-# Ignore the generated local settings file.
-gradle.properties
+# IntelliJ IDEA
+/.idea/
+# IntelliJ creates this folder, ignore.
Review comment:
This is caused by the fact that it's a composite build and we don't configure it with such extra care as we do with other projects (we don't override intellij's defaults). I don't think this matters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org