You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Ian Boston (JIRA)" <ji...@apache.org> on 2008/07/22 12:08:31 UTC

[jira] Created: (SHINDIG-467) API re-factor to extract public API's

API re-factor to extract public API's 
--------------------------------------

                 Key: SHINDIG-467
                 URL: https://issues.apache.org/jira/browse/SHINDIG-467
             Project: Shindig
          Issue Type: Improvement
          Components: RESTful API (Java)
            Reporter: Ian Boston


Currently the package structure of the Social API's doesn't distinguish between public API's, internal API's and implementations. There appears to be support to address this issue, so I am opening this JIRA to pull together a straw-man for this re-factoring.




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SHINDIG-467) API re-factor to extract public API's

Posted by "Ian Boston (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ian Boston updated SHINDIG-467:
-------------------------------

    Attachment: SHINDIG-467.summary

A summary of the re-factoring showing how things have moved.

> API re-factor to extract public API's 
> --------------------------------------
>
>                 Key: SHINDIG-467
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-467
>             Project: Shindig
>          Issue Type: Improvement
>          Components: RESTful API (Java)
>            Reporter: Ian Boston
>         Attachments: SHINDIG-467.patch, SHINDIG-467.summary
>
>
> Currently the package structure of the Social API's doesn't distinguish between public API's, internal API's and implementations. There appears to be support to address this issue, so I am opening this JIRA to pull together a straw-man for this re-factoring.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (SHINDIG-467) API re-factor to extract public API's

Posted by "Ian Boston (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ian Boston closed SHINDIG-467.
------------------------------

    Resolution: Fixed

Closing

> API re-factor to extract public API's 
> --------------------------------------
>
>                 Key: SHINDIG-467
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-467
>             Project: Shindig
>          Issue Type: Improvement
>          Components: RESTful API (Java)
>            Reporter: Ian Boston
>         Attachments: SHINDIG-467.patch, SHINDIG-467.summary
>
>
> Currently the package structure of the Social API's doesn't distinguish between public API's, internal API's and implementations. There appears to be support to address this issue, so I am opening this JIRA to pull together a straw-man for this re-factoring.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SHINDIG-467) API re-factor to extract public API's

Posted by "Cassie Doll (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615856#action_12615856 ] 

Cassie Doll commented on SHINDIG-467:
-------------------------------------

I think this is a good first step - so definitely commit. 
We may want to change things around a little later on but this is a great improvement. 

Thanks!

> API re-factor to extract public API's 
> --------------------------------------
>
>                 Key: SHINDIG-467
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-467
>             Project: Shindig
>          Issue Type: Improvement
>          Components: RESTful API (Java)
>            Reporter: Ian Boston
>         Attachments: SHINDIG-467.patch, SHINDIG-467.summary
>
>
> Currently the package structure of the Social API's doesn't distinguish between public API's, internal API's and implementations. There appears to be support to address this issue, so I am opening this JIRA to pull together a straw-man for this re-factoring.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SHINDIG-467) API re-factor to extract public API's

Posted by "Ian Boston (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615594#action_12615594 ] 

Ian Boston commented on SHINDIG-467:
------------------------------------

In the re-factor focused on the SPI and the Service interface ( ie the back-end API and the HTTP API), these were previously in a single package. 

Now the back-end SPI (ActivityService etc) is in o.a.s.social.opensocial.spi  and the front end API/Servlets are in o.a.s.social.opensocial.service

The model is split into o.a.s.social.opensocial.model containing the pure interfaces (eg Person) and the impl is in o.a.s.social.core.model

Simularly the OAuth parts are split into API and impl with API in o.a.s.social.opensocial.oauth and the real core implementation in o.a.s.social.core.oauth

All the test pass and the sample container runs, I will build a site to check dependency conversion.

> API re-factor to extract public API's 
> --------------------------------------
>
>                 Key: SHINDIG-467
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-467
>             Project: Shindig
>          Issue Type: Improvement
>          Components: RESTful API (Java)
>            Reporter: Ian Boston
>         Attachments: SHINDIG-467.patch, SHINDIG-467.summary
>
>
> Currently the package structure of the Social API's doesn't distinguish between public API's, internal API's and implementations. There appears to be support to address this issue, so I am opening this JIRA to pull together a straw-man for this re-factoring.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SHINDIG-467) API re-factor to extract public API's

Posted by "Ian Boston (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615937#action_12615937 ] 

Ian Boston commented on SHINDIG-467:
------------------------------------

Ok, committing,

For anyone updating I would advise a *very* clean build
eg
  rm -rf ~/.m2/repository/org/apache/shindig/
mvn clean
mvn install
mvn eclipse:clean
mvn eclipse:eclipse

and then refresh in eclipse

The last 2 depend on your preferred eclipse setup.

Ian





> API re-factor to extract public API's 
> --------------------------------------
>
>                 Key: SHINDIG-467
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-467
>             Project: Shindig
>          Issue Type: Improvement
>          Components: RESTful API (Java)
>            Reporter: Ian Boston
>         Attachments: SHINDIG-467.patch, SHINDIG-467.summary
>
>
> Currently the package structure of the Social API's doesn't distinguish between public API's, internal API's and implementations. There appears to be support to address this issue, so I am opening this JIRA to pull together a straw-man for this re-factoring.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SHINDIG-467) API re-factor to extract public API's

Posted by "Ian Boston (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ian Boston updated SHINDIG-467:
-------------------------------

    Attachment: SHINDIG-467.patch

The patch itself,

Unfortunately the patch does not show the renames quite as easily.

> API re-factor to extract public API's 
> --------------------------------------
>
>                 Key: SHINDIG-467
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-467
>             Project: Shindig
>          Issue Type: Improvement
>          Components: RESTful API (Java)
>            Reporter: Ian Boston
>         Attachments: SHINDIG-467.patch, SHINDIG-467.summary
>
>
> Currently the package structure of the Social API's doesn't distinguish between public API's, internal API's and implementations. There appears to be support to address this issue, so I am opening this JIRA to pull together a straw-man for this re-factoring.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.