You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/12/16 14:17:27 UTC

[GitHub] [camel] zregvart opened a new pull request #4778: CAMEL-12871: Salesforce streaming reliability

zregvart opened a new pull request #4778:
URL: https://github.com/apache/camel/pull/4778


   Adds a stub server implemented in Jetty, as it is already pulled in as a
   dependency, and a integration test for the testing streaming resiliency.
   
   Two cases are added in the integration test: server closing the
   TCP connection (e.g. in a abrupt server shutdown), and restarting the
   `SubscriptionHelper` service (e.g. when route is restarted).
   
   When SubscriptionHelper is stopped we need to remove all listeners and
   close channels this helper is listening on.
   
   If we can't connect and perform the handshake, disconnecting will
   trigger client restart with back-off. Also when restarting as the signal
   to restart can occur on multiple threads we need to guard against
   restart happening in parallel.
   
   - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
   - [x] Each commit in the pull request should have a meaningful subject line and body.
   - [x] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [x] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
   Below are the contribution guidelines:
   https://github.com/apache/camel/blob/master/CONTRIBUTING.md


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel] zregvart merged pull request #4778: CAMEL-12871: Salesforce streaming reliability

Posted by GitBox <gi...@apache.org>.
zregvart merged pull request #4778:
URL: https://github.com/apache/camel/pull/4778


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel] zregvart commented on pull request #4778: CAMEL-12871: Salesforce streaming reliability

Posted by GitBox <gi...@apache.org>.
zregvart commented on pull request #4778:
URL: https://github.com/apache/camel/pull/4778#issuecomment-748050681


   I'll merge this now and backport it to 3.7.1.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org