[jira] [Commented] (SCB-701) RequestBody(required = false) and when requestBody is null then exception observed

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SCB-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16524938#comment-16524938 ] 

ASF GitHub Bot commented on SCB-701:
------------------------------------

acsukesh opened a new pull request #781: [SCB-701] RequestBody(required = false) should invoke method when bod…
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/781
 
 
   …y is null
   
   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> RequestBody(required = false) and when requestBody is null then exception observed
> ----------------------------------------------------------------------------------
>
>                 Key: SCB-701
>                 URL: https://issues.apache.org/jira/browse/SCB-701
>             Project: Apache ServiceComb
>          Issue Type: Improvement
>          Components: Java-Chassis
>    Affects Versions: java-chassis-1.0.0-m2
>            Reporter: Mahesh Raju Somalaraju
>            Assignee: sukesh
>            Priority: Major
>             Fix For: java-chassis-1.0.0-m2
>
>
> RequestBody(required = false) and when requestBody is null then exception observed
>  
> @ApiOperation(value = "saysomething", notes = "saysomething")
>  @RequestMapping(path = "/saysomething", method = RequestMethod.POST)
>  @Transactional(propagation = Propagation.REQUIRED, rollbackFor = Exception.class)
>  public String saySomething(@RequestBody(required=false) @ApiParam(required=false) Person user) throws Exception {
>  if (user == null) {
>  return "please provide user details";
>  }
>  return user.getName();
>  }
>  
> When requestBody is  null then Exception is oberved.  when requestbody required is false then no Exception should come.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)