[GitHub] [pinot] snleee commented on a diff in pull request #9952: [Clean up] Do not cache PropertiesConfiguration within SegmentMetadataImpl

[GitBox <gi...@apache.org>]

snleee commented on code in PR #9952:
URL: https://github.com/apache/pinot/pull/9952#discussion_r1043948515


##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/metadata/SegmentMetadataImpl.java:
##########
@@ -92,11 +92,6 @@ public class SegmentMetadataImpl implements SegmentMetadata {
   private String _startOffset;
   private String _endOffset;
 
-  // TODO: No need to cache this. We cannot modify the metadata if it is from a input stream
-  // Caching properties around can be costly when the number of segments is high according to the
-  // finding in PR #2996. So for now, caching is used only when initializing from input streams.
-  private PropertiesConfiguration _segmentMetadataPropertiesConfiguration = null;

Review Comment:
   👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org