You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/12/06 21:19:08 UTC
[GitHub] [arrow] kou commented on a diff in pull request #14832: GH-14828: [CI][Conda] Sync with conda-forge, fix nightly jobs
kou commented on code in PR #14832:
URL: https://github.com/apache/arrow/pull/14832#discussion_r1041467521
##########
dev/tasks/conda-recipes/r-arrow/build.sh:
##########
@@ -1,9 +1,14 @@
-#!/usr/bin/env bash
-
+#!/bin/bash
set -ex
export DISABLE_AUTOBREW=1
-# See https://conda-forge.org/docs/maintainer/knowledge_base.html#newer-c-features-with-old-sdk
-export ARROW_R_CXXFLAGS="${ARROW_R_CXXFLAGS} -D_LIBCPP_DISABLE_AVAILABILITY"
-$R CMD INSTALL --build r/.
+# set C++17 due to abseil
+export ARROW_R_CXXFLAGS="${ARROW_R_CXXFLAGS} -std=c++17"
+
+if [[ "${target_platform}" == osx-* ]]; then
+ # See https://conda-forge.org/docs/maintainer/knowledge_base.html#newer-c-features-with-old-sdk
+ export ARROW_R_CXXFLAGS="${ARROW_R_CXXFLAGS} -D_LIBCPP_DISABLE_AVAILABILITY"
+fi
+
+${R} CMD INSTALL --build r/. ${R_ARGS}
Review Comment:
Could you add this note as comment in this file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org