You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/08 01:02:37 UTC
[GitHub] [doris] englefly opened a new pull request, #10691: [refactor] update stop_be.sh to avoid error message
englefly opened a new pull request, #10691:
URL: https://github.com/apache/doris/pull/10691
# Proposed changes
execute bin/stop_be.sh without any parameter, we will receive a error message:
`./stop_be.sh: 第 26 行:[: =: 期待一元表达式`
This pr aims to remove this unnecessary message.
Issue Number: close #xxx
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on a diff in pull request #10691: [refactor] update stop_be.sh to avoid error message
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on code in PR #10691:
URL: https://github.com/apache/doris/pull/10691#discussion_r916438848
##########
bin/stop_be.sh:
##########
@@ -23,7 +23,7 @@ export DORIS_HOME=`cd "$curdir/.."; pwd`
export PID_DIR=`cd "$curdir"; pwd`
signum=9
-if [ $1 = "--grace" ]; then
+if [ $# -gt 0 ] && [ $1 = "--grace" ]; then
Review Comment:
```suggestion
if [[ "$1" == "--grace" ]]; then
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #10691: [refactor] update stop_be.sh to avoid error message
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on PR #10691:
URL: https://github.com/apache/doris/pull/10691#issuecomment-1178511913
Duplicated, see #10689 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10691: [refactor] update stop_be.sh to avoid error message
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10691:
URL: https://github.com/apache/doris/pull/10691#issuecomment-1178600191
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10691: [refactor] update stop_be.sh to avoid error message
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10691:
URL: https://github.com/apache/doris/pull/10691#issuecomment-1178600215
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #10691: [refactor] update stop_be.sh to avoid error message
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #10691:
URL: https://github.com/apache/doris/pull/10691
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org