You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "hiroyuki-sato (via GitHub)" <gi...@apache.org> on 2025/07/24 13:38:26 UTC
[I] [CI][Dev] Fix shellcheck errors in the ci/scripts/integration_skyhook.sh [arrow]
hiroyuki-sato opened a new issue, #47186:
URL: https://github.com/apache/arrow/issues/47186
### Describe the enhancement requested
This is the sub issue #44748.
* SC2034: MIRROR_ID appears unused. Verify use (or export if used externally).
* SC2086: Double quote to prevent globbing and word splitting.
* SC2115: Use "${var:?}" to ensure this never expands to /* .
* SC2143: Use grep -q instead of comparing output with [ -n .. ].
```
ci/scripts/integration_skyhook.sh
In ci/scripts/integration_skyhook.sh line 37:
rm -rf ${DIR}/*
^------^ SC2115 (warning): Use "${var:?}" to ensure this never expands to /* .
In ci/scripts/integration_skyhook.sh line 47:
MIRROR_ID="m"
^-------^ SC2034 (warning): MIRROR_ID appears unused. Verify use (or export if used externally).
In ci/scripts/integration_skyhook.sh line 91:
ceph osd crush add osd.${OSD_ID} 1 root=default
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
ceph osd crush add osd."${OSD_ID}" 1 root=default
In ci/scripts/integration_skyhook.sh line 92:
ceph-osd --id ${OSD_ID} --mkjournal --mkfs
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
ceph-osd --id "${OSD_ID}" --mkjournal --mkfs
In ci/scripts/integration_skyhook.sh line 93:
ceph-osd --id ${OSD_ID} || ceph-osd --id ${OSD_ID} || ceph-osd --id ${OSD_ID}
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
ceph-osd --id "${OSD_ID}" || ceph-osd --id "${OSD_ID}" || ceph-osd --id "${OSD_ID}"
In ci/scripts/integration_skyhook.sh line 103:
while [[ ! $(ceph mds stat | grep "up:active") ]]; do sleep 1; done
^-- SC2143 (style): Use grep -q instead of comparing output with [ -n .. ].
In ci/scripts/integration_skyhook.sh line 115:
pushd ${ARROW_BUILD_DIR}
^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
pushd "${ARROW_BUILD_DIR}"
For more information:
https://www.shellcheck.net/wiki/SC2034 -- MIRROR_ID appears unused. Verify ...
https://www.shellcheck.net/wiki/SC2115 -- Use "${var:?}" to ensure this nev...
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
```
### Component(s)
Continuous Integration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [CI][Dev] Fix shellcheck errors in the ci/scripts/integration_skyhook.sh [arrow]
Posted by "hiroyuki-sato (via GitHub)" <gi...@apache.org>.
hiroyuki-sato commented on issue #47186:
URL: https://github.com/apache/arrow/issues/47186#issuecomment-3134846421
skyhook will move to anther repository. We don't need to fix this file.
https://github.com/apache/arrow/pull/47187#issuecomment-3116252330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [CI][Dev] Fix shellcheck errors in the ci/scripts/integration_skyhook.sh [arrow]
Posted by "hiroyuki-sato (via GitHub)" <gi...@apache.org>.
hiroyuki-sato closed issue #47186: [CI][Dev] Fix shellcheck errors in the ci/scripts/integration_skyhook.sh
URL: https://github.com/apache/arrow/issues/47186
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org