You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hop.apache.org by "mattcasters (via GitHub)" <gi...@apache.org> on 2026/08/13 21:07:16 UTC

[PR] Issue #7903 : Add find and replace to the explorer content editor (hop)

mattcasters opened a new pull request, #7947:
URL: https://github.com/apache/hop/pull/7947

   ## Summary
   
   - Adds Find and Find/Replace to the shared content-editor toolbar and desktop popup used by `BaseTextExplorerFileType` (Open as text, YAML, SQL, XML, logs, markdown).
   - Generalizes `FindReplaceDialog` onto `IFindReplaceTarget` so explorer tabs reuse the same dialog as `TextComposite` (next/previous, wrap, case sensitive, replace one/all).
   - Implements selection/caret/insert on the desktop SourceViewer, Hop Web fallback `Text`, and Monaco remote methods so toolbar actions work in both GUIs.
   - Ctrl+F / Ctrl+H while the editor is focused open the local dialog; Hop GUI Edit → Find (Search Everywhere) is unchanged.
   
   Fixes #7903
   
   ## Test plan
   
   - [x] Compile `ui`, `rcp`, `rap`
   - [x] Unit tests: `FindReplaceOperationsTest`, `ContentEditorActionsTest`, `TextFindSupportTest`, `GuiPluginWebCompatibilityTest`
   - [x] Spotless apply on changed modules
   - [x] Open `.hpl` / `.hwf` as text: Find and Find/Replace on toolbar and popup
   - [x] Find next/previous wraps and seeds from the current selection
   - [x] Replace one / replace all marks the file dirty
   - [x] Read-only / binary open-as-text: Find enabled, Replace disabled
   - [x] YAML / SQL / XML / markdown tabs get the same buttons
   - [x] Dialog `TextComposite` Find / Replace still works
   - [x] Editor focused: Ctrl+F opens the local dialog; graph focused: Ctrl+F still opens Search Everywhere


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Issue #7903 : Add find and replace to the explorer content editor (hop)

Posted by "hansva (via GitHub)" <gi...@apache.org>.
hansva merged PR #7947:
URL: https://github.com/apache/hop/pull/7947


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org