You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/29 11:21:49 UTC

[GitHub] [airflow] kaxil commented on pull request #9563: Use update instead of merge in _run_raw_task

kaxil commented on pull request #9563:
URL: https://github.com/apache/airflow/pull/9563#issuecomment-651049545


   > > I think we should use merge, mainly because then we don't need to care about which fields are updated for a TI.
   > 
   > I agree with this in general. Merge is really useful in many cases but it's not always an optimal solution. In this case, the question is how seriously we want to pay attention to Airflow performance.
   
   Yes I have no strong opinion either and by no means, I am an expert on SQL alchemy state handling :) so I will be very happy to learn anything new from the discussion.
   
   My only concern is about other attributes like job_id which is updated a few lines about, do we need to add job_id too in that case?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org