You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by "Kevin Hawkins (JIRA)" <ji...@apache.org> on 2012/10/30 17:34:12 UTC
[jira] [Created] (CB-1755) iOS: Allow customization of whitelist
rejection message
Kevin Hawkins created CB-1755:
---------------------------------
Summary: iOS: Allow customization of whitelist rejection message
Key: CB-1755
URL: https://issues.apache.org/jira/browse/CB-1755
Project: Apache Cordova
Issue Type: Improvement
Components: iOS
Affects Versions: 2.2.0
Reporter: Kevin Hawkins
Assignee: Shazron Abdullah
[CDVWhitelist errorStringForURL:] currently returns the hard-coded error string, "ERROR whitelist rejection: url='[failed URL]'", used when a host fails its whitelist check. It would be nice if the format string for this message could be user-defined/customized. A couple of suggested solutions:
- Access a customized message internally in errorStringForURL, by having a well-defined localization key to reference it, and defaulting to the original value if it hasn't been set.
- Add a public property on CDVWhitelist to specify it, same "default" behavior as above.
The latter is probably the most flexible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CB-1755) iOS: Allow customization of whitelist
rejection message
Posted by "Andrew Grieve (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Grieve resolved CB-1755.
-------------------------------
Resolution: Fixed
Fix Version/s: 2.3.0
Assignee: Andrew Grieve (was: Shazron Abdullah)
Commit: https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-ios.git;a=commit;h=69c1375a7e2788770e3a28cada26465591e367f1
> iOS: Allow customization of whitelist rejection message
> -------------------------------------------------------
>
> Key: CB-1755
> URL: https://issues.apache.org/jira/browse/CB-1755
> Project: Apache Cordova
> Issue Type: Improvement
> Components: iOS
> Affects Versions: 2.2.0
> Reporter: Kevin Hawkins
> Assignee: Andrew Grieve
> Labels: ios, whitelist
> Fix For: 2.3.0
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> [CDVWhitelist errorStringForURL:] currently returns the hard-coded error string, "ERROR whitelist rejection: url='[failed URL]'", used when a host fails its whitelist check. It would be nice if the format string for this message could be user-defined/customized. A couple of suggested solutions:
> - Access a customized message internally in errorStringForURL, by having a well-defined localization key to reference it, and defaulting to the original value if it hasn't been set.
> - Add a public property on CDVWhitelist to specify it, same "default" behavior as above.
> The latter is probably the most flexible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-1755) iOS: Allow customization of whitelist
rejection message
Posted by "Shazron Abdullah (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487057#comment-13487057 ]
Shazron Abdullah commented on CB-1755:
--------------------------------------
Related pull request: https://github.com/apache/incubator-cordova-ios/pull/62
> iOS: Allow customization of whitelist rejection message
> -------------------------------------------------------
>
> Key: CB-1755
> URL: https://issues.apache.org/jira/browse/CB-1755
> Project: Apache Cordova
> Issue Type: Improvement
> Components: iOS
> Affects Versions: 2.2.0
> Reporter: Kevin Hawkins
> Assignee: Shazron Abdullah
> Labels: ios, whitelist
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> [CDVWhitelist errorStringForURL:] currently returns the hard-coded error string, "ERROR whitelist rejection: url='[failed URL]'", used when a host fails its whitelist check. It would be nice if the format string for this message could be user-defined/customized. A couple of suggested solutions:
> - Access a customized message internally in errorStringForURL, by having a well-defined localization key to reference it, and defaulting to the original value if it hasn't been set.
> - Add a public property on CDVWhitelist to specify it, same "default" behavior as above.
> The latter is probably the most flexible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira